Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1778)

Unified Diff: apps/ui/native_app_window.h

Issue 27207003: Fix declaration vs. implementation ordering in NativeAppWindow{Views|Gtk} (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase again Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « apps/shell_window_registry.cc ('k') | apps/ui/views/shell_window_frame_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/ui/native_app_window.h
diff --git a/apps/native_app_window.h b/apps/ui/native_app_window.h
similarity index 93%
rename from apps/native_app_window.h
rename to apps/ui/native_app_window.h
index 834491425aae7d0d1bb24bf84368df33aa8c7f6f..c20e3b180ea0731545165f53e8962fba977f7f17 100644
--- a/apps/native_app_window.h
+++ b/apps/ui/native_app_window.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef APPS_NATIVE_APP_WINDOW_H_
-#define APPS_NATIVE_APP_WINDOW_H_
+#ifndef APPS_UI_NATIVE_APP_WINDOW_H_
+#define APPS_UI_NATIVE_APP_WINDOW_H_
#include "apps/shell_window.h"
#include "components/web_modal/web_contents_modal_dialog_host.h"
@@ -18,17 +18,7 @@ namespace apps {
class NativeAppWindow : public ui::BaseWindow,
public web_modal::WebContentsModalDialogHost {
public:
- // Called when the draggable regions are changed.
- virtual void UpdateDraggableRegions(
- const std::vector<extensions::DraggableRegion>& regions) = 0;
-
- // Returns the region used by frameless windows for dragging. May return NULL.
- virtual SkRegion* GetDraggableRegion() = 0;
-
- // Called when the region that accepts input events is changed.
- // If |region| is NULL, then the entire window will accept input events.
- virtual void UpdateInputRegion(scoped_ptr<SkRegion> region) = 0;
-
+ // Fullscreen changes may be asynchronous on some platforms.
virtual void SetFullscreen(bool fullscreen) = 0;
virtual bool IsFullscreenOrPending() const = 0;
@@ -41,6 +31,17 @@ class NativeAppWindow : public ui::BaseWindow,
// Called when the title of the window changes.
virtual void UpdateWindowTitle() = 0;
+ // Called when the draggable regions are changed.
+ virtual void UpdateDraggableRegions(
+ const std::vector<extensions::DraggableRegion>& regions) = 0;
+
+ // Returns the region used by frameless windows for dragging. May return NULL.
+ virtual SkRegion* GetDraggableRegion() = 0;
+
+ // Called when the region that accepts input events is changed.
+ // If |region| is NULL, then the entire window will accept input events.
+ virtual void UpdateInputRegion(scoped_ptr<SkRegion> region) = 0;
+
// Allows the window to handle unhandled keyboard messages coming back from
// the renderer.
virtual void HandleKeyboardEvent(
@@ -68,4 +69,4 @@ class NativeAppWindow : public ui::BaseWindow,
} // namespace apps
-#endif // APPS_NATIVE_APP_WINDOW_H_
+#endif // APPS_UI_NATIVE_APP_WINDOW_H_
« no previous file with comments | « apps/shell_window_registry.cc ('k') | apps/ui/views/shell_window_frame_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698