🏠 Remove ContentSuggestionsActivity

🏠 Remove ContentSuggestionsActivity

There is no need for this experimental activity now that we can use
the actual BottomSheet for testing purposes. Includes partial reverts
of https://crrev.com/2636533003 and https://crrev.com/2593523005

BUG=677672
Review-Url: https://codereview.chromium.org/2720693004
Cr-Commit-Position: refs/heads/master@{#454276}
Committed: https://chromium.googlesource.com/chromium/src/+/a6d53528275dd00edf03ddc1da5b3afdf3fa80a0

[dgn, 2017-02-27 15:04:56]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 15:05:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgn, 2017-02-27 15:07:02]

dgn@chromium.org changed reviewers:
+ asvitkine@chromium.org, bauerb@chromium.org

[dgn, 2017-02-27 15:07:02]

asvitkine@: PTAL at the histogram.xml changes. I'm just removing a flag.

bauerb@: PTAL at everything

[vitaliii, 2017-02-27 15:09:27]

On 2017/02/27 15:07:02, dgn wrote:
> asvitkine@: PTAL at the histogram.xml changes. I'm just removing a flag.
> 
> bauerb@: PTAL at everything

In https://codereview.chromium.org/2696563002/ asvitkine@ wrote:
"If you're only updating an enum in histograms.xml, I'm OK if you TBR me."

[Alexei Svitkine (slow), 2017-02-27 15:41:28]

https://codereview.chromium.org/2720693004/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2720693004/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:97903: -  <int value="7444737"
label="NTPSuggestionsStandaloneUI:disabled"/>
Keep the flags here.

It's used to decode data from previous Chrome versions.

[dgn, 2017-02-27 15:57:26]

PTAL

https://codereview.chromium.org/2720693004/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2720693004/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:97903: -  <int value="7444737"
label="NTPSuggestionsStandaloneUI:disabled"/>
On 2017/02/27 15:41:27, Alexei Svitkine (slow) wrote:
> Keep the flags here.
> 
> It's used to decode data from previous Chrome versions.

Added back the flag and added a comment to indicated that entries should be
kept.

[dgn, 2017-02-27 15:57:32]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 15:57:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-02-27 16:22:08]

lgtm, thanks!

[commit-bot: I haz the power, 2017-02-27 17:06:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 17:06:57]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-03-01 10:46:36]

LGTM, thanks!

[dgn, 2017-03-01 10:58:11]

The CQ bit was checked by dgn@chromium.org

[commit-bot: I haz the power, 2017-03-01 10:58:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 12:15:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 12:15:47]

Failed to apply patch for chrome/browser/android/chrome_feature_list.cc:
While running git apply --index -p1;
  error: patch failed: chrome/browser/android/chrome_feature_list.cc:58
  error: chrome/browser/android/chrome_feature_list.cc: patch does not apply

Patch:       chrome/browser/android/chrome_feature_list.cc
Index: chrome/browser/android/chrome_feature_list.cc
diff --git a/chrome/browser/android/chrome_feature_list.cc
b/chrome/browser/android/chrome_feature_list.cc
index
b8aa5376d470629a0162d66a2dfe042391cf2260..e11852b61968d372b92987a57e81dc051365082b
100644
--- a/chrome/browser/android/chrome_feature_list.cc
+++ b/chrome/browser/android/chrome_feature_list.cc
@@ -58,7 +58,6 @@ const base::Feature* kFeaturesExposedToJava[] = {
     &kNTPFakeOmniboxTextFeature,
     &kNTPOfflinePagesFeature,
     &NTPShowGoogleGInOmniboxFeature,
-    &kNTPSuggestionsStandaloneUIFeature,
     &kPhysicalWebFeature,
     &kPhysicalWebSharing,
     &kSpecialLocaleFeature,
@@ -144,9 +143,6 @@ const base::Feature
kNTPOfflinePagesFeature{"NTPOfflinePages",
 const base::Feature NTPShowGoogleGInOmniboxFeature{
     "NTPShowGoogleGInOmnibox", base::FEATURE_DISABLED_BY_DEFAULT};
 
-const base::Feature kNTPSuggestionsStandaloneUIFeature{
-    "NTPSuggestionsStandaloneUI", base::FEATURE_DISABLED_BY_DEFAULT};
-
 const base::Feature kPhysicalWebFeature{"PhysicalWeb",
                                         base::FEATURE_ENABLED_BY_DEFAULT};

[dgn, 2017-03-02 15:14:22]

The CQ bit was checked by dgn@chromium.org

[dgn, 2017-03-02 15:14:23]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2720693004/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-02 15:14:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 16:20:32]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488467662921630,
"parent_rev": "3576ed36444623a399f8c2d627e2c34539f44436", "commit_rev":
"a6d53528275dd00edf03ddc1da5b3afdf3fa80a0"}

[commit-bot: I haz the power, 2017-03-02 16:21:30]

Description was changed from

==========
🏠 Remove ContentSuggestionsActivity

There is no need for this experimental activity now that we can use
the actual BottomSheet for testing purposes. Includes partial reverts
of https://crrev.com/2636533003 and https://crrev.com/2593523005

BUG=677672
==========

to

==========
🏠 Remove ContentSuggestionsActivity

There is no need for this experimental activity now that we can use
the actual BottomSheet for testing purposes. Includes partial reverts
of https://crrev.com/2636533003 and https://crrev.com/2593523005

BUG=677672

Review-Url: https://codereview.chromium.org/2720693004
Cr-Commit-Position: refs/heads/master@{#454276}
Committed:
https://chromium.googlesource.com/chromium/src/+/a6d53528275dd00edf03ddc1da5b...
==========

[commit-bot: I haz the power, 2017-03-02 16:21:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a6d53528275dd00edf03ddc1da5b...