Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2339)

Issue 2720613004: [Fuchsia] Adds an option to create_sdk.py to skip binary stripping (Closed)

Created:
3 years, 9 months ago by zra
Modified:
3 years, 9 months ago
Reviewers:
Bill Hesse, Cutch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[Fuchsia] Adds an option to create_sdk.py to skip binary stripping create_sdk.py tries to use the host 'strip' instead of the 'strip' from the build's toolchain. fixes #28900 R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/6c08487f4776841201585bdd771c35596548f87e

Patch Set 1 #

Patch Set 2 : Rename flag no_strip -> disable_stripping #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tools/create_sdk.py View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
zra
3 years, 9 months ago (2017-02-27 23:07:45 UTC) #3
Bill Hesse
LGTM
3 years, 9 months ago (2017-02-27 23:22:09 UTC) #5
zra
3 years, 9 months ago (2017-02-27 23:35:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6c08487f4776841201585bdd771c35596548f87e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698