Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1920)

Unified Diff: tools/create_sdk.py

Issue 2720613004: [Fuchsia] Adds an option to create_sdk.py to skip binary stripping (Closed)
Patch Set: Rename flag no_strip -> disable_stripping Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/create_sdk.py
diff --git a/tools/create_sdk.py b/tools/create_sdk.py
index f461d3b9b5f5340a796f655448ece8a8ac8683f8..9c1e51f54af9a72ce21eb6674ef5ec3d292efa52 100755
--- a/tools/create_sdk.py
+++ b/tools/create_sdk.py
@@ -96,6 +96,9 @@ def GetOptions():
options.add_option("--copy_libs",
action="store_true", default=False,
help='Copy dynamically linked libraries to the SDK bin directory.')
+ options.add_option("--disable_stripping",
+ action="store_true", default=False,
+ help='Do not try to strip binaries. Use when they are already stripped')
return options.parse_args()
@@ -237,9 +240,9 @@ def Main():
copyfile(dart_src_binary, dart_dest_binary)
copymode(dart_src_binary, dart_dest_binary)
# Strip the binaries on platforms where that is supported.
- if HOST_OS == 'linux':
+ if HOST_OS == 'linux' and not options.disable_stripping:
subprocess.call(['strip', dart_dest_binary])
- elif HOST_OS == 'macos':
+ elif HOST_OS == 'macos' and not options.disable_stripping:
subprocess.call(['strip', '-x', dart_dest_binary])
#
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698