Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2720593003: //third_party/WebKit/public: include v8 as a user, not system, header (Closed)

Created:
3 years, 9 months ago by dcheng
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

//third_party/WebKit/public: include v8 as a user, not system, header BUG=688155 Review-Url: https://codereview.chromium.org/2720593003 Cr-Commit-Position: refs/heads/master@{#453179} Committed: https://chromium.googlesource.com/chromium/src/+/f65878729393c484e6a25ea8a91394d7f5d11e10

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M third_party/WebKit/public/web/WebDOMActivityLogger.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebKit.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebPlugin.h View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/public/web/WebPluginContainer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebTestingSupport.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dcheng
3 years, 9 months ago (2017-02-27 08:44:38 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-02-27 08:48:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720593003/1
3 years, 9 months ago (2017-02-27 10:06:44 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 10:10:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f65878729393c484e6a25ea8a913...

Powered by Google App Engine
This is Rietveld 408576698