Change the string representation of Slow2G ECT

Change the string representation of Slow2G ECT

Change the string representation of Slow2G to include a dash for better
readability.

BUG=696612
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2720513002
Cr-Commit-Position: refs/heads/master@{#453622}
Committed: https://chromium.googlesource.com/chromium/src/+/1476cc6a0abbfe9f9154c398f98335f6b2bd0eaa

[tbansal1, 2017-02-25 23:55:10]

Description was changed from

==========
Change the string representation of ECT

BUG=
==========

to

==========
Change the string representation of Slow2G ECT

Change the string representation of Slow2G to include a dash for better
readability.

BUG=
==========

[tbansal1, 2017-02-26 08:27:33]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-26 08:27:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-02-26 08:27:43]

The CQ bit was unchecked by tbansal@chromium.org

[tbansal1, 2017-02-26 08:27:58]

Description was changed from

==========
Change the string representation of Slow2G ECT

Change the string representation of Slow2G to include a dash for better
readability.

BUG=
==========

to

==========
Change the string representation of Slow2G ECT

Change the string representation of Slow2G to include a dash for better
readability.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-02-26 08:28:07]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-26 08:28:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-26 08:54:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-26 08:54:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tbansal1, 2017-02-27 17:09:01]

Patchset #2 (id:20001) has been deleted

[tbansal1, 2017-02-27 17:09:09]

Patchset #1 (id:1) has been deleted

[tbansal1, 2017-02-27 17:09:13]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 17:09:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-02-27 17:12:28]

Description was changed from

==========
Change the string representation of Slow2G ECT

Change the string representation of Slow2G to include a dash for better
readability.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Change the string representation of Slow2G ECT

Change the string representation of Slow2G to include a dash for better
readability.

BUG=696612
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[commit-bot: I haz the power, 2017-02-27 17:39:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 17:39:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[tbansal1, 2017-02-27 17:44:31]

Patchset #1 (id:40001) has been deleted

[tbansal1, 2017-02-27 17:44:37]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 17:45:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 18:19:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 18:19:51]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tbansal1, 2017-02-27 18:24:02]

Patchset #1 (id:60001) has been deleted

[tbansal1, 2017-02-27 18:24:06]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 18:24:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 19:43:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 19:43:41]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-02-27 21:54:32]

tbansal@chromium.org changed reviewers:
+ ryansturm@chromium.org

[tbansal1, 2017-02-27 21:54:33]

ryansturm: ptal. Thanks.

[RyanSturm, 2017-02-28 03:00:03]

Not a huge fan of the deprecated method, but I see why it's necessary. LGTM %
nit

https://codereview.chromium.org/2720513002/diff/80001/net/nqe/effective_conne...
File net/nqe/effective_connection_type.cc (right):

https://codereview.chromium.org/2720513002/diff/80001/net/nqe/effective_conne...
net/nqe/effective_connection_type.cc:38: return "";
Should you add NOTREACHED to this case?

[tbansal1, 2017-02-28 05:38:39]

https://codereview.chromium.org/2720513002/diff/80001/net/nqe/effective_conne...
File net/nqe/effective_connection_type.cc (right):

https://codereview.chromium.org/2720513002/diff/80001/net/nqe/effective_conne...
net/nqe/effective_connection_type.cc:38: return "";
On 2017/02/28 03:00:02, Ryan Sturm wrote:
> Should you add NOTREACHED to this case?

Done.

[tbansal1, 2017-02-28 05:38:48]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 05:39:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 07:23:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 07:23:47]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-02-28 16:34:42]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2017-02-28 16:34:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
ryansturm@chromium.org
Link to the patchset: https://codereview.chromium.org/2720513002/#ps120001
(title: "ryansturm comments")

[commit-bot: I haz the power, 2017-02-28 16:35:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 16:44:58]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1488299682196790,
"parent_rev": "afc9d60e96d31a11f756d5c56c2be54a28130960", "commit_rev":
"1476cc6a0abbfe9f9154c398f98335f6b2bd0eaa"}

[commit-bot: I haz the power, 2017-02-28 16:46:20]

Description was changed from

==========
Change the string representation of Slow2G ECT

Change the string representation of Slow2G to include a dash for better
readability.

BUG=696612
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Change the string representation of Slow2G ECT

Change the string representation of Slow2G to include a dash for better
readability.

BUG=696612
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2720513002
Cr-Commit-Position: refs/heads/master@{#453622}
Committed:
https://chromium.googlesource.com/chromium/src/+/1476cc6a0abbfe9f9154c398f983...
==========

[commit-bot: I haz the power, 2017-02-28 16:46:21]

Committed patchset #3 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/1476cc6a0abbfe9f9154c398f983...