MD Settings: add more extension controlled pref handling.

MD Settings: add more extension controlled pref handling.

This previously existing code was removed earlier, but turns out to be necessary so adding the code back.

BUG=693226
Review-Url: https://codereview.chromium.org/2720503007
Cr-Commit-Position: refs/heads/master@{#453673}
Committed: https://chromium.googlesource.com/chromium/src/+/a37a3c270737739b63bca0dc46e7ee2e1d1ebdd4

[scottchen, 2017-02-28 17:45:14]

scottchen@chromium.org changed reviewers:
+ dbeam@chromium.org, dschuyler@chromium.org, stevenjb@chromium.org

[scottchen, 2017-02-28 17:45:15]

As per offline discussion with dbeam, adding some code back from here:
https://codereview.chromium.org/2479973002/diff/180001/chrome/browser/extensi...

I tried to look for the minimum amount of change to make the
extension-controlled information work as we want. 

I tested this change with autofill pref, and dave tested this change with the
fonts pref, both of which weren't showing the controlled info before, but with
this CL they start working correctly again.

[scottchen, 2017-02-28 17:47:39]

On 2017/02/28 17:45:15, scottchen wrote:
> As per offline discussion with dbeam, adding some code back from here:
>
https://codereview.chromium.org/2479973002/diff/180001/chrome/browser/extensi...
> 
> I tried to look for the minimum amount of change to make the
> extension-controlled information work as we want. 
> 
> I tested this change with autofill pref, and dave tested this change with the
> fonts pref, both of which weren't showing the controlled info before, but with
> this CL they start working correctly again.

@stevenjb regarding my question about the user-modifiable and
supervisor-controlled check that was also removed in the previous CL - 
I looked at it closer and it doesn't seem to be related to extension-specific
attributes, so I don't plan on addressing that in this CL, unless you guys think
otherwise.

[Dan Beam, 2017-02-28 17:52:46]

lgtm but it'd be cool if we actually started testing this file (I don't see any
tests currently :/)

https://codereview.chromium.org/2720503007/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/settings_private/prefs_util.cc (right):

https://codereview.chromium.org/2720503007/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/settings_private/prefs_util.cc:745:
->GetExtensionControllingPref(pref_object.key);
if (extension_id.empty())
  return nullptr;

[scottchen, 2017-02-28 18:56:14]

Will note to add tests and address it in a future CL.

https://codereview.chromium.org/2720503007/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/settings_private/prefs_util.cc (right):

https://codereview.chromium.org/2720503007/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/settings_private/prefs_util.cc:745:
->GetExtensionControllingPref(pref_object.key);
On 2017/02/28 17:52:45, Dan Beam wrote:
> if (extension_id.empty())
>   return nullptr;

Done.

[scottchen, 2017-02-28 18:56:27]

The CQ bit was checked by scottchen@chromium.org

[scottchen, 2017-02-28 18:56:28]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2720503007/#ps60001
(title: "add early return for empty id. also format.")

[commit-bot: I haz the power, 2017-02-28 18:57:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stevenjb, 2017-02-28 19:14:38]

lgtm

[dschuyler, 2017-02-28 19:32:30]

lgtm

[commit-bot: I haz the power, 2017-02-28 19:45:00]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488308187481650,
"parent_rev": "08e6bdcd00b6b07b9269ae38de22fd0e8b7e65ac", "commit_rev":
"a37a3c270737739b63bca0dc46e7ee2e1d1ebdd4"}

[commit-bot: I haz the power, 2017-02-28 19:45:35]

Description was changed from

==========
MD Settings: add more extension controlled pref handling.

This previously existing code was removed earlier, but turns out to be necessary
so adding the code back.

BUG=693226
==========

to

==========
MD Settings: add more extension controlled pref handling.

This previously existing code was removed earlier, but turns out to be necessary
so adding the code back.

BUG=693226

Review-Url: https://codereview.chromium.org/2720503007
Cr-Commit-Position: refs/heads/master@{#453673}
Committed:
https://chromium.googlesource.com/chromium/src/+/a37a3c270737739b63bca0dc46e7...
==========

[commit-bot: I haz the power, 2017-02-28 19:45:36]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a37a3c270737739b63bca0dc46e7...