Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2720483002: Add missing variable in gyp file. (Closed)

Created:
3 years, 10 months ago by Franzi
Modified:
3 years, 10 months ago
Reviewers:
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add missing variable in gyp file. Node.js doesn't build because v8_extra_library_files is used but not defined in v8.gyp. We can probably clean up the build file and properly delete v8_extra_library_files, just want to get the integration build green again. TBR=adamk@chromium.org BUG= Review-Url: https://codereview.chromium.org/2720483002 Cr-Commit-Position: refs/heads/master@{#43429} Committed: https://chromium.googlesource.com/v8/v8/+/4310cd02d2160b1457baed81a2f40063eb264a21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720483002/1
3 years, 10 months ago (2017-02-25 12:12:02 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-25 12:13:46 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/4310cd02d2160b1457baed81a2f40063eb2...

Powered by Google App Engine
This is Rietveld 408576698