Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2720473002: MD Downloads: announce search results (Closed)

Created:
3 years, 10 months ago by Dan Beam
Modified:
3 years, 9 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, asanka, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: announce search results This doesn't solve the incremental-ness, but it kind of sidesteps it as well as needing to pluralize this (previously unused) message. R=dmazzoni@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2720473002 Cr-Commit-Position: refs/heads/master@{#453342} Committed: https://chromium.googlesource.com/chromium/src/+/9676b2b5ce049987c535320f37e22d27bdc2307d

Patch Set 1 : . #

Patch Set 2 : closure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M chrome/browser/resources/md_downloads/compiled_resources2.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/manager.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/manager.js View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.js View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Dan Beam
3 years, 10 months ago (2017-02-25 02:08:27 UTC) #3
Dan Beam
this announces Search results for '<search term>' when 1+ matches are found. This works ok ...
3 years, 10 months ago (2017-02-25 02:09:40 UTC) #4
dmazzoni
lgtm
3 years, 9 months ago (2017-02-27 20:05:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720473002/40001
3 years, 9 months ago (2017-02-27 20:08:45 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 21:25:44 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9676b2b5ce049987c535320f37e2...

Powered by Google App Engine
This is Rietveld 408576698