Hack analysis macros for Windows to avoid compiler bug

base/logging.h

Index: base/logging.h
diff --git a/base/logging.h b/base/logging.h
index c969f3dcc1684bacbfa11ebec5f54d158c20a780..3221b687c4300e89b0887b17a62ab97f928ebabd 100644
--- a/base/logging.h
+++ b/base/logging.h
@@ -320,7 +320,9 @@ inline constexpr TVal&& AnalysisAssumeTrue(TVal&& arg) {
   return std::forward<TVal>(arg);
 }
 
-#define ANALYZER_ASSUME_TRUE(val) ::logging::AnalysisAssumeTrue(val)
+// Disable using AnalysisAssumeTrue because of VC++ compiler bug
+// https://connect.microsoft.com/VisualStudio/feedback/details/3124774

[Wez, 2017/02/25 00:25:47]

This is the same as the no-analysis case, below, so fold the two together? Or is
the plan to re-enable this if the compiler gets fixed?

+#define ANALYZER_ASSUME_TRUE(val) (val)
 
 #else  // !_PREFAST_ & !__clang_analyzer__