Hack analysis macros for Windows to avoid compiler bug

base/logging.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_LOGGING_H_
 #define BASE_LOGGING_H_
 
 #include <stddef.h>
 
 #include <cassert>
@@ skipping 302 matching lines @@
 #elif defined(_PREFAST_) && defined(OS_WIN)
 
 // |arg| is a universal reference for compatibility with lvalue and rvalue
 // arguments.
 template <typename TVal>
 inline constexpr TVal&& AnalysisAssumeTrue(TVal&& arg) {
   __analysis_assume(!!arg);
   return std::forward<TVal>(arg);
 }
 
-#define ANALYZER_ASSUME_TRUE(val) ::logging::AnalysisAssumeTrue(val)
+// Disable using AnalysisAssumeTrue because of VC++ compiler bug
+// https://connect.microsoft.com/VisualStudio/feedback/details/3124774

[Wez, 2017/02/25 00:25:47]

This is the same as the no-analysis case, below, so fold the two together? Or is
the plan to re-enable this if the compiler gets fixed?

+#define ANALYZER_ASSUME_TRUE(val) (val)
 
 #else  // !_PREFAST_ & !__clang_analyzer__
 
 #define ANALYZER_ASSUME_TRUE(val) (val)
 
 #endif  // !_PREFAST_ & !__clang_analyzer__
 
 typedef int LogSeverity;
 const LogSeverity LOG_VERBOSE = -1;  // This is level 1 verbosity
 // Note: the log severities are used to index into the array of names,
@@ skipping 796 matching lines @@
 #elif NOTIMPLEMENTED_POLICY == 5
 #define NOTIMPLEMENTED() do {\
   static bool logged_once = false;\
   LOG_IF(ERROR, !logged_once) << NOTIMPLEMENTED_MSG;\
   logged_once = true;\
 } while(0);\
 EAT_STREAM_PARAMETERS
 #endif
 
 #endif  // BASE_LOGGING_H_