Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 2720443002: Adjust version checks for GetCertificate* patching (Closed)

Created:
3 years, 10 months ago by brucedawson
Modified:
3 years, 10 months ago
Reviewers:
forshaw
CC:
chromium-reviews, wfh+watch_chromium.org, pennymac+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust version checks for GetCertificate* patching The functions GetCertificateByHandle and GetCertificateSizeByHandle need patching but only when they exist. An incorrect version check meant that Chrome tried to patch then on Windows 10.0.10240 which would then fail on debug builds. BUG=696043 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2720443002 Cr-Commit-Position: refs/heads/master@{#452995} Committed: https://chromium.googlesource.com/chromium/src/+/692a736b8eb29f607f29cfdfacb77aa9d3fa4109

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sandbox/win/src/process_mitigations_win32k_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (9 generated)
forshaw
On 2017/02/24 22:01:18, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
3 years, 10 months ago (2017-02-24 22:06:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720443002/1
3 years, 10 months ago (2017-02-24 23:25:53 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 23:35:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/692a736b8eb29f607f29cfdfacb7...

Powered by Google App Engine
This is Rietveld 408576698