Invoke AttachmentUploader and update AttachmentIds.

sync/api/attachments/attachment_service_impl.h

Index: sync/api/attachments/attachment_service_impl.h
diff --git a/sync/api/attachments/attachment_service_impl.h b/sync/api/attachments/attachment_service_impl.h
index f833b6f4596cb55a4d1e1464dd4d57b2e8941bf8..6de4ba9f515495baad56c4d860c4461dc2eb6a9c 100644
--- a/sync/api/attachments/attachment_service_impl.h
+++ b/sync/api/attachments/attachment_service_impl.h
@@ -19,7 +19,8 @@ class SYNC_EXPORT AttachmentServiceImpl : public AttachmentService,
                                           public base::NonThreadSafe {
  public:
   AttachmentServiceImpl(scoped_ptr<AttachmentStore> attachment_store,
-                        scoped_ptr<AttachmentUploader> attachment_uploader);
+                        scoped_ptr<AttachmentUploader> attachment_uploader,
+                        Delegate* delegate);

[maniscalco, 2014/05/15 20:09:28]

Can you please document the delegate parameter?  We should call out some things
explicitly:

1. The delegate is not owned by the ASI.

2. The delegate must outlive the ASI.

3. The delegate is optional (pass NULL if you don't want/need a delegate).

[pavely, 2014/05/16 00:19:10]

Done.

   virtual ~AttachmentServiceImpl();
 
   // Create an AttachmentServiceImpl suitable for use in tests.
@@ -45,9 +46,12 @@ class SYNC_EXPORT AttachmentServiceImpl : public AttachmentService,
                 const AttachmentStore::Result& result);
   void WriteDone(const StoreCallback& callback,
                  const AttachmentStore::Result& result);
+  void UploadDone(const AttachmentUploader::UploadResult& result,
+                  const AttachmentId& attachment_id);
 
   const scoped_ptr<AttachmentStore> attachment_store_;
   const scoped_ptr<AttachmentUploader> attachment_uploader_;
+  Delegate* delegate_;
   // Must be last data member.
   base::WeakPtrFactory<AttachmentServiceImpl> weak_ptr_factory_;