Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: components/sync_driver/sync_api_component_factory.h

Issue 272043002: Invoke AttachmentUploader and update AttachmentIds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Initialize through SyncApiComponentFactory Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_driver/sync_api_component_factory.h
diff --git a/components/sync_driver/sync_api_component_factory.h b/components/sync_driver/sync_api_component_factory.h
index cdb5a42db5e0cbe473741bf9125cba40809aa79c..62a2b6030424bd1520e9e3141bd120e830f9c4e1 100644
--- a/components/sync_driver/sync_api_component_factory.h
+++ b/components/sync_driver/sync_api_component_factory.h
@@ -7,6 +7,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
+#include "sync/api/attachments/attachment_service.h"
#include "sync/api/attachments/attachment_store.h"
maniscalco 2014/05/15 20:09:28 No longer needed?
pavely 2014/05/16 00:19:10 Done.
#include "sync/api/syncable_service.h"
#include "sync/internal_api/public/base/model_type.h"
@@ -23,11 +24,10 @@ class SyncApiComponentFactory {
virtual base::WeakPtr<syncer::SyncableService> GetSyncableServiceForType(
syncer::ModelType type) = 0;
- // Returns the custom attachment store for a model type, if there is one.
- // May return NULL, which implies sync should use a default implementation.
+ // Creates attachment service.
// Note: Should only be called from the model type thread.
maniscalco 2014/05/15 20:09:28 Please document the delegate parameter (does not o
pavely 2014/05/16 00:19:10 Done.
- virtual scoped_ptr<syncer::AttachmentStore>
- CreateCustomAttachmentStoreForType(syncer::ModelType type) = 0;
+ virtual scoped_ptr<syncer::AttachmentService> CreateAttachmentService(
+ syncer::AttachmentService::Delegate* delegate) = 0;
};
} // namespace browser_sync

Powered by Google App Engine
This is Rietveld 408576698