Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2720413006: DevTools: debug remote modules loaded by ServiceManager (Closed)

Created:
3 years, 9 months ago by chenwilliam
Modified:
3 years, 9 months ago
Reviewers:
paulirish, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: debug remote modules loaded by ServiceManager BUG=688109 Review-Url: https://codereview.chromium.org/2720413006 Cr-Commit-Position: refs/heads/master@{#454351} Committed: https://chromium.googlesource.com/chromium/src/+/34cea6ca365e21616db3c3f3707c6f25f487b38d

Patch Set 1 #

Patch Set 2 : fixup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
chenwilliam
ptal!
3 years, 9 months ago (2017-03-02 02:36:10 UTC) #2
paulirish
lgtm this does the trick for the audits remote module
3 years, 9 months ago (2017-03-02 04:49:44 UTC) #3
pfeldman
lgtm
3 years, 9 months ago (2017-03-02 15:30:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720413006/20001
3 years, 9 months ago (2017-03-02 18:35:03 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 19:52:48 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/34cea6ca365e21616db3c3f3707c...

Powered by Google App Engine
This is Rietveld 408576698