Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2720413004: Links in generation prompts should go to passwords.google.com (Mac). (Closed)

Created:
3 years, 9 months ago by dvadym
Modified:
3 years, 9 months ago
Reviewers:
vasilii
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Links in generation prompts should go to passwords.google.com (Mac). Screenshots for more context are on the bug https://bugs.chromium.org/p/chromium/issues/detail?id=695468#c1 BUG=695468 Review-Url: https://codereview.chromium.org/2720413004 Cr-Commit-Position: refs/heads/master@{#453938} Committed: https://chromium.googlesource.com/chromium/src/+/5bfa37111b4826928a2e67b7c0a5dc0b99904d7c

Patch Set 1 #

Patch Set 2 : Test fix #

Patch Set 3 : small test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller_unittest.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
dvadym
Hi Vasilii, could you please review this CL? Regards, Vadym
3 years, 9 months ago (2017-03-01 14:25:36 UTC) #3
vasilii
lgtm
3 years, 9 months ago (2017-03-01 15:23:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720413004/40001
3 years, 9 months ago (2017-03-01 15:25:00 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 15:39:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5bfa37111b4826928a2e67b7c0a5...

Powered by Google App Engine
This is Rietveld 408576698