Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2720403002: Rename ShortcutHelper::FetchSplashScreenImage() parameters to reflect correct units (Closed)

Created:
3 years, 9 months ago by pkotwicz
Modified:
3 years, 9 months ago
Reviewers:
dominickn
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ShortcutHelper::FetchSplashScreenImage() parameters to reflect correct units ShortcutHelper::FetchSplashScreenImage() gets the "ideal size" and the "minimum size" in pixels not density independant pixels. BUG=696132 Review-Url: https://codereview.chromium.org/2720403002 Cr-Commit-Position: refs/heads/master@{#453848} Committed: https://chromium.googlesource.com/chromium/src/+/bd0dac0340caf61da16475a45fa372199e3b8c00

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/android/shortcut_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
pkotwicz
Dominick, can you please take a look? This was something which was missed from https://codereview.chromium.org/2589503002/
3 years, 9 months ago (2017-03-01 00:17:49 UTC) #2
dominickn
lgtm
3 years, 9 months ago (2017-03-01 00:37:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720403002/1
3 years, 9 months ago (2017-03-01 04:17:57 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 05:05:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bd0dac0340caf61da16475a45fa3...

Powered by Google App Engine
This is Rietveld 408576698