Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2720363002: Revert of [Media Router] Remove binary messaging implementation. (Closed)

Created:
3 years, 9 months ago by jam
Modified:
3 years, 9 months ago
Reviewers:
mark a. foltz, whywhat
CC:
agrieve+watch_chromium.org, chfremer+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, media-router+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Media Router] Remove binary messaging implementation. (patchset #1 id:1 of https://codereview.chromium.org/2720273003/ ) Reason for revert: Breaks the build. Original issue's description: > [Media Router] Remove binary messaging implementation. > > This removes the binary messaging implementation for Media Router from Android, > as there are no plans to support it for Cast. > > BUG=524128 > R=avayvod@chromium.org > > Review-Url: https://codereview.chromium.org/2720273003 . > Cr-Commit-Position: refs/heads/master@{#453709} > Committed: https://chromium.googlesource.com/chromium/src/+/ebdab4190ceb21a9ba4a5d8e719df9ab94b2716e TBR=avayvod@chromium.org,mfoltz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=524128 Review-Url: https://codereview.chromium.org/2720363002 Cr-Commit-Position: refs/heads/master@{#453729} Committed: https://chromium.googlesource.com/chromium/src/+/e9aeb1792103e88435b765da22ba37ff80960887

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/router/MediaRouteProvider.java View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/media/android/router/media_router_android.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jam
Created Revert of [Media Router] Remove binary messaging implementation.
3 years, 9 months ago (2017-02-28 22:28:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720363002/1
3 years, 9 months ago (2017-02-28 22:29:39 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 22:31:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e9aeb1792103e88435b765da22ba...

Powered by Google App Engine
This is Rietveld 408576698