Misc. cleanup for theme provider code, including:...

Misc. cleanup for theme provider code, including:
* Use correct indentation/alignment in a number of places
* Use early-return to avoid long code block indenting
* Use for() instead of while() in cases where that's what the code is actually doing
* Consistent naming for iterators ("foo_iter", "bar_iter" instead of sometimes that way and sometimes "found")
* Use {} when needed, don't use when not
* Do not use "else" after "return"
* Shorten overly-verbose code
* Pull some trivial functions into the header
* Eliminate unused function
* Use STLDeleteValues() helper where appropriate

Some of this was originally in my patch that modified constness, but I've split it out to make that more sane.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28771

[Peter Kasting, 2009-10-12 23:39:51]

Miranda, you want to look at this since Glen is out?

[Miranda Callahan, 2009-10-12 23:41:34]

Gladly, I'll look at it right now...

On 2009/10/12 23:39:51, Peter Kasting wrote:
> Miranda, you want to look at this since Glen is out?

[Miranda Callahan, 2009-10-12 23:57:13]

LGTM with a nit, and noticing an earlier mistake I had made in the code.  Thanks
for your work on this -- a great improvement!

http://codereview.chromium.org/272033/diff/1007/2009
File chrome/browser/browser_theme_provider.cc (right):

http://codereview.chromium.org/272033/diff/1007/2009#newcode201
Line 201: typedef std::map<const int, int> FrameTintMap;
should this typedef go in browser_theme_provider.h with the other typedefs?

http://codereview.chromium.org/272033/diff/1007/2009#newcode846
Line 846: std::map<int, SkBitmap*>::iterator it =
themed_image_cache_.find(base_id);
hmmm, I see now that I should have made this an ImageCache::iterator, since the
type was already defined.

[Peter Kasting, 2009-10-13 00:17:19]

http://codereview.chromium.org/272033/diff/1007/2009
File chrome/browser/browser_theme_provider.cc (right):

http://codereview.chromium.org/272033/diff/1007/2009#newcode201
Line 201: typedef std::map<const int, int> FrameTintMap;
On 2009/10/12 23:57:13, Miranda Callahan wrote:
> should this typedef go in browser_theme_provider.h with the other typedefs?

No, because this object isn't a class member, it's file-static.  I changed
"frame_tints_" to "frame_tints" (and similarly with "themeable_images_") to make
it clear that they're not members of anything.

There are some problems with these types; I filed crbug.com/24677 about those.