Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: chrome/browser/browser_theme_provider_mac.mm

Issue 272033: Misc. cleanup for theme provider code, including:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_theme_provider_gtk.cc ('k') | chrome/browser/gtk/gtk_theme_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_theme_provider_mac.mm
===================================================================
--- chrome/browser/browser_theme_provider_mac.mm (revision 28595)
+++ chrome/browser/browser_theme_provider_mac.mm (working copy)
@@ -31,9 +31,9 @@
return nil;
// Check to see if we already have the image in the cache.
- NSImageMap::const_iterator found = nsimage_cache_.find(id);
- if (found != nsimage_cache_.end())
- return found->second;
+ NSImageMap::const_iterator nsimage_iter = nsimage_cache_.find(id);
+ if (nsimage_iter != nsimage_cache_.end())
+ return nsimage_iter->second;
// Why don't we load the file directly into the image instead of the whole
// SkBitmap > native conversion?
@@ -71,9 +71,9 @@
DCHECK(CalledOnValidThread());
// Check to see if we already have the color in the cache.
- NSColorMap::const_iterator found = nscolor_cache_.find(id);
- if (found != nscolor_cache_.end())
- return found->second;
+ NSColorMap::const_iterator nscolor_iter = nscolor_cache_.find(id);
+ if (nscolor_iter != nscolor_cache_.end())
+ return nscolor_iter->second;
SkColor sk_color = GetColor(id);
NSColor* color = [NSColor
@@ -95,9 +95,9 @@
DCHECK(CalledOnValidThread());
// Check to see if we already have the color in the cache.
- NSColorMap::const_iterator found = nscolor_cache_.find(id);
- if (found != nscolor_cache_.end())
- return found->second;
+ NSColorMap::const_iterator nscolor_iter = nscolor_cache_.find(id);
+ if (nscolor_iter != nscolor_cache_.end())
+ return nscolor_iter->second;
TintMap::iterator tint_iter = tints_.find(GetTintKey(id));
if (tint_iter != tints_.end()) {
« no previous file with comments | « chrome/browser/browser_theme_provider_gtk.cc ('k') | chrome/browser/gtk/gtk_theme_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698