Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2720223002: [MD WebUI] Use html_out_file as prefix for depfile. (Closed)

Created:
3 years, 9 months ago by calamity
Modified:
3 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD WebUI] Use html_out_file as prefix for depfile. This CL fixes an issue where changing the out file of a vulcanize build would not cause the depfile to be retargeted, leading to a stale depfile and breaking builds. BUG=673825 Review-Url: https://codereview.chromium.org/2720223002 Cr-Commit-Position: refs/heads/master@{#453515} Committed: https://chromium.googlesource.com/chromium/src/+/133b4458dc3c57dd9d1212f5a35abc48e352b550

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/vulcanize.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
calamity
3 years, 9 months ago (2017-02-28 04:07:53 UTC) #3
Dan Beam
lgtm
3 years, 9 months ago (2017-02-28 04:11:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720223002/1
3 years, 9 months ago (2017-02-28 04:21:50 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 05:58:08 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/133b4458dc3c57dd9d1212f5a35a...

Powered by Google App Engine
This is Rietveld 408576698