mash: makes ash/public/cpp bundle ash/public/interfaces

mash: makes ash/public/cpp bundle ash/public/interfaces

A future change is going to require ash/public/cpp depend upon
ash/public/interfaces. Because of typemaps ash/public/interfaces
already depends upon ash/public/cpp. This means we would have a
cycle. To fix this I'm making ash/public/interfaces only visible to
ash/public/cpp and ash/public/cpp has a public_dep on
ash/public/interfaces.

BUG=697206
TEST=none
R=rockot@chromium.org, tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2720203004
Cr-Commit-Position: refs/heads/master@{#454106}
Committed: https://chromium.googlesource.com/chromium/src/+/350894479de57f66b60eb51726d96e1aab991374

[sky, 2017-02-28 22:00:10]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 22:01:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 22:36:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 22:36:31]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[sky, 2017-03-01 00:33:11]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 00:34:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-03-01 00:36:54]

sky@chromium.org changed reviewers:
+ reveman@chromium.org

[sky, 2017-03-01 00:37:26]

reveman for arc
tsepez for typemaps
rockot the rest

[commit-bot: I haz the power, 2017-03-01 01:25:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 01:25:58]

Dry run: This issue passed the CQ dry run.

[reveman, 2017-03-01 16:23:19]

reveman@chromium.org changed reviewers:
+ lhchavez@chromium.org

[reveman, 2017-03-01 16:23:20]

-me
+lhchavez for components/arc

[Luis Héctor Chávez, 2017-03-01 16:57:26]

lgtm

[Ken Rockot(use gerrit already), 2017-03-01 16:59:31]

lgtm

[Tom Sepez, 2017-03-01 20:13:49]

lgtm

[sky, 2017-03-01 20:14:26]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-03-01 20:15:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 20:30:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 20:30:16]

Failed to apply patch for ash/public/interfaces/BUILD.gn:
While running git apply --index -p1;
  error: patch failed: ash/public/interfaces/BUILD.gn:4
  error: ash/public/interfaces/BUILD.gn: patch does not apply

Patch:       ash/public/interfaces/BUILD.gn
Index: ash/public/interfaces/BUILD.gn
diff --git a/ash/public/interfaces/BUILD.gn b/ash/public/interfaces/BUILD.gn
index
b0128049b589836b08b5b7f3a8f91b5270ca00eb..3ce626903281ed9ad81509c82f1b23f2ae7f1e46
100644
--- a/ash/public/interfaces/BUILD.gn
+++ b/ash/public/interfaces/BUILD.gn
@@ -4,7 +4,13 @@
 
 import("//mojo/public/tools/bindings/mojom.gni")
 
-mojom("interfaces") {
+# Depend upon //ash/public/cpp:ash_public_cpp, which has a public_dep on this.
+# The two targets must be bundled together as the typemaps depend upon
+# //ash/public/cpp, and //ash/public/cpp needs to depend on this for generated
+# code (such as enums and constants).
+mojom("interfaces_internal") {
+  visibility = [ "//ash/public/cpp:ash_public_cpp" ]
+
   sources = [
     "accelerator_controller.mojom",
     "ash_window_type.mojom",
@@ -28,4 +34,8 @@ mojom("interfaces") {
     "//components/signin/public/interfaces",
     "//skia/public/interfaces",
   ]
+
+  export_class_attribute = "ASH_PUBLIC_EXPORT"
+  export_define = "ASH_PUBLIC_IMPLEMENTATION=1"
+  export_header = "ash/public/cpp/ash_public_export.h"
 }

[sky, 2017-03-01 22:43:21]

The CQ bit was checked by sky@chromium.org

[sky, 2017-03-01 22:43:22]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org, lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2720203004/#ps40001
(title: "merge")

[commit-bot: I haz the power, 2017-03-01 22:44:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 00:04:29]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488408201574680,
"parent_rev": "5a729d1bc790d94120ec942a4566bb85f969cdb1", "commit_rev":
"350894479de57f66b60eb51726d96e1aab991374"}

[commit-bot: I haz the power, 2017-03-02 00:05:05]

Description was changed from

==========
mash: makes ash/public/cpp bundle ash/public/interfaces

A future change is going to require ash/public/cpp depend upon
ash/public/interfaces. Because of typemaps ash/public/interfaces
already depends upon ash/public/cpp. This means we would have a
cycle. To fix this I'm making ash/public/interfaces only visible to
ash/public/cpp and ash/public/cpp has a public_dep on
ash/public/interfaces.

BUG=697206
TEST=none
R=rockot@chromium.org, tsepez@chromium.org
==========

to

==========
mash: makes ash/public/cpp bundle ash/public/interfaces

A future change is going to require ash/public/cpp depend upon
ash/public/interfaces. Because of typemaps ash/public/interfaces
already depends upon ash/public/cpp. This means we would have a
cycle. To fix this I'm making ash/public/interfaces only visible to
ash/public/cpp and ash/public/cpp has a public_dep on
ash/public/interfaces.

BUG=697206
TEST=none
R=rockot@chromium.org, tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2720203004
Cr-Commit-Position: refs/heads/master@{#454106}
Committed:
https://chromium.googlesource.com/chromium/src/+/350894479de57f66b60eb51726d9...
==========

[commit-bot: I haz the power, 2017-03-02 00:05:07]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/350894479de57f66b60eb51726d9...