Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: chrome/browser/ui/views/page_info/page_info_bubble_view.cc

Issue 2720183002: [Views] Update ink drop for omnibox icons (Closed)
Patch Set: Fixed tests and added comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/page_info/page_info_bubble_view.cc
diff --git a/chrome/browser/ui/views/page_info/page_info_bubble_view.cc b/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
index 2281bcaf57aff0dbd57a87b6359dd17ad289977c..56aeced6d6997f0a426b9f35936a1824128e6300 100644
--- a/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
+++ b/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
@@ -58,6 +58,7 @@
#include "ui/views/layout/layout_manager.h"
#include "ui/views/view.h"
#include "ui/views/widget/widget.h"
+#include "ui/views/widget/widget_observer.h"
#include "url/gurl.h"
namespace {
@@ -345,6 +346,7 @@ PageInfoBubbleView::~PageInfoBubbleView() {}
// static
void PageInfoBubbleView::ShowBubble(
views::View* anchor_view,
+ views::WidgetObserver* widget_observer,
const gfx::Rect& anchor_rect,
Profile* profile,
content::WebContents* web_contents,
@@ -361,6 +363,8 @@ void PageInfoBubbleView::ShowBubble(
new InternalPageInfoBubbleView(anchor_view, parent_window, url);
if (!anchor_view)
bubble->SetAnchorRect(anchor_rect);
+ if (widget_observer)
+ bubble->GetWidget()->AddObserver(widget_observer);
bubble->GetWidget()->Show();
return;
}
@@ -368,6 +372,8 @@ void PageInfoBubbleView::ShowBubble(
anchor_view, parent_window, profile, web_contents, url, security_info);
if (!anchor_view)
bubble->SetAnchorRect(anchor_rect);
+ if (widget_observer)
+ bubble->GetWidget()->AddObserver(widget_observer);
bubble->GetWidget()->Show();
}

Powered by Google App Engine
This is Rietveld 408576698