ui/views/animation/ink_drop_host_view.h - Issue 2720183002: [Views] Update ink drop for omnibox icons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/animation/ink_drop_host_view.h

Issue 2720183002: [Views] Update ink drop for omnibox icons (Closed)

Patch Set: Fixed tests and added comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/animation/ink_drop_host_view.h

diff --git a/ui/views/animation/ink_drop_host_view.h b/ui/views/animation/ink_drop_host_view.h

index 151992097c1171866a94e8170f5bcd5686c53b27..c5679c6e002f7ac2ad72076e48fde77a18cf19c4 100644

--- a/ui/views/animation/ink_drop_host_view.h

+++ b/ui/views/animation/ink_drop_host_view.h

@@ -107,6 +107,8 @@ class VIEWS_EXPORT InkDropHostView : public View, public InkDropHost {

// Subclasses can override to return a mask for the ink drop. By default,

// returns nullptr (i.e no mask).

+ // TODO(bruthig): InkDropMasks do not currently work on Windows. See

bruthig 2017/05/01 22:42:18 Thx for adding this!

spqchan 2017/05/02 22:50:05 No prob~

+ // crbug.com/713359.

virtual std::unique_ptr<views::InkDropMask> CreateInkDropMask() const;

// Provides access to |ink_drop_|. Implements lazy initialization of