Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2720163003: Add ScopedTaskScheduler to RenderWidgetHostViewChildFrameTest (Closed)

Created:
3 years, 9 months ago by tzik
Modified:
3 years, 9 months ago
Reviewers:
alexmos
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ScopedTaskScheduler to RenderWidgetHostViewChildFrameTest RenderWidgetHostViewChildFrameTest.VerifyRequestContextTypeForFrameTree was failing due to missing TaskScheduler used by RenderWidgetHostImpl constructor. This CL adds a ScopedTaskScheduler to the test fixture and re-enables the disabled test. BUG=696919 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc View 3 chunks +6 lines, -8 lines 1 comment Download

Messages

Total messages: 14 (11 generated)
tzik
PTAL
3 years, 9 months ago (2017-02-28 14:01:40 UTC) #5
Charlie Reis
Thanks for getting this started! It looks like it's still failing on the try bots, ...
3 years, 9 months ago (2017-02-28 17:38:21 UTC) #13
alexmos
3 years, 9 months ago (2017-02-28 18:00:37 UTC) #14
Thanks for fixing this!  This seems to be the same as issue 695375?

https://codereview.chromium.org/2720163003/diff/1/content/browser/frame_host/...
File content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
(right):

https://codereview.chromium.org/2720163003/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc:74:
RenderWidgetHostViewChildFrameTest() {}
Not sure if that'll fix the trybot failures, but do you need to initialize
task_scheduler_ with the message_loop_, like you did in
https://codereview.chromium.org/2710053003/ ?

Powered by Google App Engine
This is Rietveld 408576698