Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "content/browser/frame_host/render_widget_host_view_child_frame.h" | 5 #include "content/browser/frame_host/render_widget_host_view_child_frame.h" |
| 6 | 6 |
| 7 #include <stdint.h> | 7 #include <stdint.h> |
| 8 | 8 |
| 9 #include <utility> | 9 #include <utility> |
| 10 | 10 |
| 11 #include "base/macros.h" | 11 #include "base/macros.h" |
| 12 #include "base/memory/ptr_util.h" | 12 #include "base/memory/ptr_util.h" |
| 13 #include "base/message_loop/message_loop.h" | 13 #include "base/message_loop/message_loop.h" |
| 14 #include "base/run_loop.h" | 14 #include "base/run_loop.h" |
| 15 #include "base/single_thread_task_runner.h" | 15 #include "base/single_thread_task_runner.h" |
| 16 #include "base/test/scoped_task_scheduler.h" | |
| 16 #include "build/build_config.h" | 17 #include "build/build_config.h" |
| 17 #include "cc/surfaces/surface.h" | 18 #include "cc/surfaces/surface.h" |
| 18 #include "cc/surfaces/surface_factory.h" | 19 #include "cc/surfaces/surface_factory.h" |
| 19 #include "cc/surfaces/surface_manager.h" | 20 #include "cc/surfaces/surface_manager.h" |
| 20 #include "cc/surfaces/surface_sequence.h" | 21 #include "cc/surfaces/surface_sequence.h" |
| 21 #include "content/browser/compositor/test/no_transport_image_transport_factory.h " | 22 #include "content/browser/compositor/test/no_transport_image_transport_factory.h " |
| 22 #include "content/browser/frame_host/cross_process_frame_connector.h" | 23 #include "content/browser/frame_host/cross_process_frame_connector.h" |
| 23 #include "content/browser/gpu/compositor_util.h" | 24 #include "content/browser/gpu/compositor_util.h" |
| 24 #include "content/browser/renderer_host/render_widget_host_delegate.h" | 25 #include "content/browser/renderer_host/render_widget_host_delegate.h" |
| 25 #include "content/browser/renderer_host/render_widget_host_impl.h" | 26 #include "content/browser/renderer_host/render_widget_host_impl.h" |
| (...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 63 return nullptr; | 64 return nullptr; |
| 64 } | 65 } |
| 65 | 66 |
| 66 cc::SurfaceInfo last_surface_info_; | 67 cc::SurfaceInfo last_surface_info_; |
| 67 }; | 68 }; |
| 68 | 69 |
| 69 } // namespace | 70 } // namespace |
| 70 | 71 |
| 71 class RenderWidgetHostViewChildFrameTest : public testing::Test { | 72 class RenderWidgetHostViewChildFrameTest : public testing::Test { |
| 72 public: | 73 public: |
| 73 RenderWidgetHostViewChildFrameTest() {} | 74 RenderWidgetHostViewChildFrameTest() {} |
|
alexmos
2017/02/28 18:00:36
Not sure if that'll fix the trybot failures, but d
| |
| 74 | 75 |
| 75 void SetUp() override { | 76 void SetUp() override { |
| 76 browser_context_.reset(new TestBrowserContext); | 77 browser_context_.reset(new TestBrowserContext); |
| 77 | 78 |
| 78 // ImageTransportFactory doesn't exist on Android. | 79 // ImageTransportFactory doesn't exist on Android. |
| 79 #if !defined(OS_ANDROID) | 80 #if !defined(OS_ANDROID) |
| 80 ImageTransportFactory::InitializeForUnitTests( | 81 ImageTransportFactory::InitializeForUnitTests( |
| 81 base::WrapUnique(new NoTransportImageTransportFactory)); | 82 base::WrapUnique(new NoTransportImageTransportFactory)); |
| 82 #else | 83 #else |
| 83 ContextProviderFactoryImpl::Initialize(&gpu_channel_factory_); | 84 ContextProviderFactoryImpl::Initialize(&gpu_channel_factory_); |
| (...skipping 30 matching lines...) Expand all Loading... | |
| 114 ContextProviderFactoryImpl::Terminate(); | 115 ContextProviderFactoryImpl::Terminate(); |
| 115 #endif | 116 #endif |
| 116 } | 117 } |
| 117 | 118 |
| 118 cc::SurfaceId GetSurfaceId() const { | 119 cc::SurfaceId GetSurfaceId() const { |
| 119 return cc::SurfaceId(view_->frame_sink_id_, view_->local_surface_id_); | 120 return cc::SurfaceId(view_->frame_sink_id_, view_->local_surface_id_); |
| 120 } | 121 } |
| 121 | 122 |
| 122 protected: | 123 protected: |
| 123 base::MessageLoopForUI message_loop_; | 124 base::MessageLoopForUI message_loop_; |
| 125 | |
| 126 // Needed by RenderWidgetHostImpl constructor on Windows. | |
| 127 base::test::ScopedTaskScheduler task_scheduler_; | |
| 128 | |
| 124 std::unique_ptr<BrowserContext> browser_context_; | 129 std::unique_ptr<BrowserContext> browser_context_; |
| 125 MockRenderWidgetHostDelegate delegate_; | 130 MockRenderWidgetHostDelegate delegate_; |
| 126 | 131 |
| 127 // Tests should set these to NULL if they've already triggered their | 132 // Tests should set these to NULL if they've already triggered their |
| 128 // destruction. | 133 // destruction. |
| 129 RenderWidgetHostImpl* widget_host_; | 134 RenderWidgetHostImpl* widget_host_; |
| 130 RenderWidgetHostViewChildFrame* view_; | 135 RenderWidgetHostViewChildFrame* view_; |
| 131 MockCrossProcessFrameConnector* test_frame_connector_; | 136 MockCrossProcessFrameConnector* test_frame_connector_; |
| 132 | 137 |
| 133 #if defined(OS_ANDROID) | 138 #if defined(OS_ANDROID) |
| (...skipping 17 matching lines...) Expand all Loading... | |
| 151 } | 156 } |
| 152 | 157 |
| 153 TEST_F(RenderWidgetHostViewChildFrameTest, VisibilityTest) { | 158 TEST_F(RenderWidgetHostViewChildFrameTest, VisibilityTest) { |
| 154 view_->Show(); | 159 view_->Show(); |
| 155 ASSERT_TRUE(view_->IsShowing()); | 160 ASSERT_TRUE(view_->IsShowing()); |
| 156 | 161 |
| 157 view_->Hide(); | 162 view_->Hide(); |
| 158 ASSERT_FALSE(view_->IsShowing()); | 163 ASSERT_FALSE(view_->IsShowing()); |
| 159 } | 164 } |
| 160 | 165 |
| 161 // http://crbug.com/696919 | |
| 162 #if defined(OS_WIN) | |
| 163 #define MAYBE_SwapCompositorFrame DISABLED_SwapCompositorFrame | |
| 164 #else | |
| 165 #define MAYBE_SwapCompositorFrame SwapCompositorFrame | |
| 166 #endif | |
| 167 | |
| 168 // Verify that OnSwapCompositorFrame behavior is correct when a delegated | 166 // Verify that OnSwapCompositorFrame behavior is correct when a delegated |
| 169 // frame is received from a renderer process. | 167 // frame is received from a renderer process. |
| 170 TEST_F(RenderWidgetHostViewChildFrameTest, MAYBE_SwapCompositorFrame) { | 168 TEST_F(RenderWidgetHostViewChildFrameTest, SwapCompositorFrame) { |
| 171 gfx::Size view_size(100, 100); | 169 gfx::Size view_size(100, 100); |
| 172 gfx::Rect view_rect(view_size); | 170 gfx::Rect view_rect(view_size); |
| 173 float scale_factor = 1.f; | 171 float scale_factor = 1.f; |
| 174 | 172 |
| 175 view_->SetSize(view_size); | 173 view_->SetSize(view_size); |
| 176 view_->Show(); | 174 view_->Show(); |
| 177 | 175 |
| 178 view_->OnSwapCompositorFrame( | 176 view_->OnSwapCompositorFrame( |
| 179 0, CreateDelegatedFrame(scale_factor, view_size, view_rect)); | 177 0, CreateDelegatedFrame(scale_factor, view_size, view_rect)); |
| 180 | 178 |
| (...skipping 10 matching lines...) Expand all Loading... | |
| 191 #endif | 189 #endif |
| 192 | 190 |
| 193 // Surface ID should have been passed to CrossProcessFrameConnector to | 191 // Surface ID should have been passed to CrossProcessFrameConnector to |
| 194 // be sent to the embedding renderer. | 192 // be sent to the embedding renderer. |
| 195 EXPECT_EQ(cc::SurfaceInfo(id, scale_factor, view_size), | 193 EXPECT_EQ(cc::SurfaceInfo(id, scale_factor, view_size), |
| 196 test_frame_connector_->last_surface_info_); | 194 test_frame_connector_->last_surface_info_); |
| 197 } | 195 } |
| 198 } | 196 } |
| 199 | 197 |
| 200 } // namespace content | 198 } // namespace content |
| OLD | NEW |