[heap] Remove Marking::MarkBlack and some minor cleanups.

[heap] Remove Marking::MarkBlack and some minor cleanups.

BUG=chromium:694255
Review-Url: https://codereview.chromium.org/2720133005
Cr-Commit-Position: refs/heads/master@{#43519}
Committed: https://chromium.googlesource.com/v8/v8/+/c45d065edc0ca83ca342cdb49e69a9203e532007

[Hannes Payer (out of office), 2017-02-28 15:36:17]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 15:36:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ulan, 2017-02-28 15:43:47]

ulan@chromium.org changed reviewers:
+ ulan@chromium.org

[ulan, 2017-02-28 15:43:47]

lgtm with comment

https://codereview.chromium.org/2720133005/diff/1/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):

https://codereview.chromium.org/2720133005/diff/1/src/heap/mark-compact.h#new...
src/heap/mark-compact.h:69: V8_INLINE static void ClearMarkBit(HeapObject* obj)
{
If object is black at the callsites, can we just used BlackToWhite(obj) directly
and remove this function?

It is not clear from the name that the object must be black.

[commit-bot: I haz the power, 2017-02-28 15:58:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 15:58:16]

Dry run: Try jobs failed on following builders:
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)
  v8_linux_verify_csa_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng_...)

[Hannes Payer (out of office), 2017-03-01 13:48:43]

Description was changed from

==========
[heap] Remove Marking::MarkBlack and Marking::MarkWhite.

BUG=chromium:694255
==========

to

==========
[heap] Remove Marking::MarkBlack and some minor cleanups.

BUG=chromium:694255
==========

[Hannes Payer (out of office), 2017-03-01 13:49:18]

https://codereview.chromium.org/2720133005/diff/1/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):

https://codereview.chromium.org/2720133005/diff/1/src/heap/mark-compact.h#new...
src/heap/mark-compact.h:69: V8_INLINE static void ClearMarkBit(HeapObject* obj)
{
On 2017/02/28 15:43:47, ulan wrote:
> If object is black at the callsites, can we just used BlackToWhite(obj)
directly
> and remove this function?
> 
> It is not clear from the name that the object must be black.

No we cannot, since the object can also be grey (when marking aborts).

[Hannes Payer (out of office), 2017-03-01 13:49:30]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 13:49:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 14:17:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 14:17:44]

Dry run: This issue passed the CQ dry run.

[Hannes Payer (out of office), 2017-03-01 14:51:51]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2017-03-01 14:51:51]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/2720133005/#ps20001
(title: "fix failures")

[commit-bot: I haz the power, 2017-03-01 14:52:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 14:53:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488379911082810,
"parent_rev": "b23b2c107b5d79fa1dbc7035cda17d668ad5f4f6", "commit_rev":
"c45d065edc0ca83ca342cdb49e69a9203e532007"}

[commit-bot: I haz the power, 2017-03-01 14:53:25]

Description was changed from

==========
[heap] Remove Marking::MarkBlack and some minor cleanups.

BUG=chromium:694255
==========

to

==========
[heap] Remove Marking::MarkBlack and some minor cleanups.

BUG=chromium:694255

Review-Url: https://codereview.chromium.org/2720133005
Cr-Commit-Position: refs/heads/master@{#43519}
Committed:
https://chromium.googlesource.com/v8/v8/+/c45d065edc0ca83ca342cdb49e69a9203e5...
==========

[commit-bot: I haz the power, 2017-03-01 14:53:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/c45d065edc0ca83ca342cdb49e69a9203e5...