Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2720133003: Revert of [Atomics] Implement ldaxr/stlxr instructions in ARM64 simulator (Closed)

Created:
3 years, 9 months ago by Dan Ehrenberg
Modified:
3 years, 9 months ago
Reviewers:
Jarin, aseemgarg, jbramley, binji
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Atomics] Implement ldaxr/stlxr instructions in ARM64 simulator (patchset #8 id:140001 of https://codereview.chromium.org/2711473002/ ) Reason for revert: The tree is closed due to an msan violation (use of uninitialized value) in the arm64 simulator soon after this patch landed; this seems related https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/13607/steps/Check/logs/simulator_invalidate_.. Original issue's description: > [Atomics] Implement ldaxr/stlxr instructions in ARM64 simulator > > BUG=v8:4614 > R=binji@chromium.org > > Review-Url: https://codereview.chromium.org/2711473002 > Cr-Commit-Position: refs/heads/master@{#43461} > Committed: https://chromium.googlesource.com/v8/v8/+/a2a2c1b9eeccd86e77f2c7e6eda3e1b09bb5306c TBR=binji@chromium.org,jarin@chromium.org,jacob.bramley@arm.com,aseemgarg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4614 Review-Url: https://codereview.chromium.org/2720133003 Cr-Commit-Position: refs/heads/master@{#43463} Committed: https://chromium.googlesource.com/v8/v8/+/2362f869a4675c10890397ab5d9694b4ac13f009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -767 lines) Patch
M src/arm64/constants-arm64.h View 1 chunk +1 line, -8 lines 0 comments Download
M src/arm64/simulator-arm64.h View 1 chunk +0 lines, -91 lines 0 comments Download
M src/arm64/simulator-arm64.cc View 7 chunks +1 line, -283 lines 0 comments Download
M test/cctest/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/test-simulator-arm64.cc View 1 chunk +0 lines, -383 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Dan Ehrenberg
Created Revert of [Atomics] Implement ldaxr/stlxr instructions in ARM64 simulator
3 years, 9 months ago (2017-02-27 22:47:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720133003/1
3 years, 9 months ago (2017-02-27 22:47:08 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 22:47:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2362f869a4675c10890397ab5d9694b4ac1...

Powered by Google App Engine
This is Rietveld 408576698