Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2720093004: Fix ProcessMemoryDumpTest.TakeAllDumpsFrom under msan (Closed)

Created:
3 years, 9 months ago by Nico
Modified:
3 years, 9 months ago
Reviewers:
ssid
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org, Primiano Tucci (use gerrit)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ProcessMemoryDumpTest.TakeAllDumpsFrom under msan. https://codereview.chromium.org/2582453002 broke this. BUG=697172 Review-Url: https://codereview.chromium.org/2720093004 Cr-Commit-Position: refs/heads/master@{#453721} Committed: https://chromium.googlesource.com/chromium/src/+/d6c9b97e0d5402918f030e48e0528f9fe5649861

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M base/trace_event/memory_dump_session_state.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Nico
3 years, 9 months ago (2017-02-28 20:38:37 UTC) #3
ssid
lgtm thanks
3 years, 9 months ago (2017-02-28 21:08:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720093004/1
3 years, 9 months ago (2017-02-28 21:11:20 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 22:12:03 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d6c9b97e0d5402918f030e48e052...

Powered by Google App Engine
This is Rietveld 408576698