chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc - Issue 2720083002: Make OnDataTimedout and OnDidPerformInstallableCheck mutually exclusive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

Issue 2720083002: Make OnDataTimedout and OnDidPerformInstallableCheck mutually exclusive. (Closed)

Patch Set: Remove redundant else and add TODO for tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc ('K') | « chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

index c8bfaf1bf4f3ad4f56063c92402ec05061852373..49252bc7b36954d23a82c7cffef4634d61372a70 100644

--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

@@ -33,6 +33,8 @@

#include "ui/gfx/image/image_unittest_util.h"

#include "url/gurl.h"

+// TODO(697228): Fix slow & incomplete tests.

dominickn 2017/02/28 23:17:12 TODO(zpeng): Add tests for <things to add tests fo

F 2017/02/28 23:22:06 Done. Thanks!

namespace {

const char* kDefaultManifestUrl = "https://www.example.com/manifest.json";

« chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc ('K') | « chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc ('k') | no next file » | no next file with comments »