Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

Issue 2720083002: Make OnDataTimedout and OnDidPerformInstallableCheck mutually exclusive. (Closed)
Patch Set: Remove redundant else and add TODO for tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
index 2dea7aa3a00b0457d742b1b3fc685e6c50b030e1..308503f90974d730d905dd4c063cc4cdcd4acce7 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
@@ -212,6 +212,9 @@ void AddToHomescreenDataFetcher::OnDidPerformInstallableCheck(
if (!web_contents() || !weak_observer_)
return;
+ if (is_installable_check_complete_)
dominickn 2017/02/28 23:17:12 Combine the two conditionals: if (!web_contents()
F 2017/02/28 23:22:06 Done.
+ return;
+
is_installable_check_complete_ = true;
bool webapk_compatible = false;

Powered by Google App Engine
This is Rietveld 408576698