Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3929)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

Issue 2720083002: Make OnDataTimedout and OnDidPerformInstallableCheck mutually exclusive. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
index 2dea7aa3a00b0457d742b1b3fc685e6c50b030e1..8091cf667fc057e9ad63bfd30e8240a50976b143 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
@@ -212,7 +212,10 @@ void AddToHomescreenDataFetcher::OnDidPerformInstallableCheck(
if (!web_contents() || !weak_observer_)
return;
- is_installable_check_complete_ = true;
+ if (is_installable_check_complete_)
+ return;
pkotwicz 2017/02/27 23:30:38 Nit: You can remove the else In Chrome we prefer
F 2017/02/28 23:09:42 Done.
+ else
+ is_installable_check_complete_ = true;
bool webapk_compatible = false;
if (check_webapk_compatibility_) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698