Make OnDataTimedout and OnDidPerformInstallableCheck mutually exclusive.

chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 194 matching lines @@
   }
 }
 
 void AddToHomescreenDataFetcher::OnDidPerformInstallableCheck(
     const InstallableData& data) {
   badge_icon_.reset();
 
   if (!web_contents() || !weak_observer_)
     return;
 
-  is_installable_check_complete_ = true;
+  if (is_installable_check_complete_)
+    return;

[pkotwicz, 2017/02/27 23:30:38]

Nit:
You can remove the else

In Chrome we prefer
if (a) {
  // do work
  return;
}
// do work


Instead of
if (a) {
  // do work
  return;
} else {
  // do work
}

[F, 2017/02/28 23:09:42]

Done.

+  else
+    is_installable_check_complete_ = true;
 
   bool webapk_compatible = false;
   if (check_webapk_compatibility_) {
     webapk_compatible = (data.error_code == NO_ERROR_DETECTED &&
                          AreWebManifestUrlsWebApkCompatible(data.manifest));
     weak_observer_->OnDidDetermineWebApkCompatibility(webapk_compatible);
 
     if (webapk_compatible) {
       // WebAPKs are wholly defined by the Web Manifest. Ignore the <meta> tag
       // data received in OnDidGetWebApplicationInfo().
@@ skipping 118 matching lines @@
 void AddToHomescreenDataFetcher::NotifyObserver(const SkBitmap& primary_icon) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   if (!web_contents() || !weak_observer_ || is_icon_saved_)
     return;
 
   is_icon_saved_ = true;
   primary_icon_ = primary_icon;
   is_ready_ = true;
   weak_observer_->OnDataAvailable(shortcut_info_, primary_icon_, badge_icon_);
 }