Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2720073003: Wire up Finch experiment to MojoLoading flag (Closed)

Created:
3 years, 9 months ago by tzik
Modified:
3 years, 9 months ago
Reviewers:
kinuko, haraken, yhirano
CC:
chromium-reviews, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Wire up Finch experiment to MojoLoading flag Add an entry to content features for MojoLoading, so that we can experiment it on Finch. BUG=603396 Review-Url: https://codereview.chromium.org/2720073003 Cr-Commit-Position: refs/heads/master@{#453562} Committed: https://chromium.googlesource.com/chromium/src/+/f9ae27fa739d2a97c7c9d546d71b1aac8dcc442e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M content/child/runtime_features.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_features.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
tzik
PTAL
3 years, 9 months ago (2017-02-28 07:52:21 UTC) #4
yhirano
lgtm
3 years, 9 months ago (2017-02-28 08:34:07 UTC) #7
tzik
Adding kinuko@ and haraken@ for owner review. PTAL to: kinuko: //content haraken: web
3 years, 9 months ago (2017-02-28 08:37:41 UTC) #10
haraken
WebKit LGTM
3 years, 9 months ago (2017-02-28 08:43:42 UTC) #11
kinuko
lgtm
3 years, 9 months ago (2017-02-28 08:48:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720073003/1
3 years, 9 months ago (2017-02-28 10:00:03 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 10:06:24 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f9ae27fa739d2a97c7c9d546d71b...

Powered by Google App Engine
This is Rietveld 408576698