Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 2719993004: cocoa: draw tabstrip stroke in white in increase-contrast incognito (Closed)

Created:
3 years, 9 months ago by Elly Fong-Jones
Modified:
3 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cocoa: draw tabstrip stroke in white in increase-contrast incognito The black stroke is nearly impossible to see against the dark theme. BUG=619922 Review-Url: https://codereview.chromium.org/2719993004 Cr-Commit-Position: refs/heads/master@{#457152} Committed: https://chromium.googlesource.com/chromium/src/+/af21d513d5715633fb63f879b78074bb15af8f6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -8 lines) Patch
M chrome/browser/ui/cocoa/tabs/tab_strip_view.mm View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_view.mm View 6 chunks +51 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Elly Fong-Jones
shrike: ptal? :)
3 years, 9 months ago (2017-02-27 19:07:13 UTC) #3
Elly Fong-Jones
mark: ptal? :)
3 years, 9 months ago (2017-03-15 17:17:04 UTC) #5
Mark Mentovai
Contrasty. LGTM.
3 years, 9 months ago (2017-03-15 17:29:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719993004/1
3 years, 9 months ago (2017-03-15 17:49:52 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 18:54:10 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/af21d513d5715633fb63f879b780...

Powered by Google App Engine
This is Rietveld 408576698