Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2719973003: mash: makes OverflowButtonActiveInkDropTest.TouchContextMenu early out (Closed)

Created:
3 years, 9 months ago by sky
Modified:
3 years, 9 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: makes OverflowButtonActiveInkDropTest.TouchContextMenu early out It appears to be flaky. BUG=696769, 695751 TEST=test only change R=msw@chromium.org TBR=msw@chromium.org Review-Url: https://codereview.chromium.org/2719973003 Cr-Commit-Position: refs/heads/master@{#453408} Committed: https://chromium.googlesource.com/chromium/src/+/98d7a599f145f9e5ad5b5f6a47dc1998045f16c8

Patch Set 1 #

Patch Set 2 : wrong test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ash/shelf/shelf_view_unittest.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
sky
3 years, 9 months ago (2017-02-27 23:57:11 UTC) #2
msw
lgtm
3 years, 9 months ago (2017-02-27 23:57:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719973003/20001
3 years, 9 months ago (2017-02-27 23:58:09 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 00:19:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/98d7a599f145f9e5ad5b5f6a47dc...

Powered by Google App Engine
This is Rietveld 408576698