Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 2719913002: bindings: Add idl_types.IdlRecordType. (Closed)

Created:
3 years, 9 months ago by Raphael Kubo da Costa (rakuco)
Modified:
3 years, 9 months ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Add idl_types.IdlRecordType. Part 2 of adding support for record<K,V> WebIDL types to the bindings generator. This CL lands the uncontroversial bits that the idl_* side (as opposed to the v8_* side) of the scripts will need: - A new IdlRecordType type that wraps a record<K,V> and holds information about its key and value types. - Code to parse Record nodes and convert them into IdlRecordTypes when parsing IDL files. In practice, this is still a no-op, as we do not do anything with this new IDL type just yet. BUG=685754 R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org Review-Url: https://codereview.chromium.org/2719913002 Cr-Commit-Position: refs/heads/master@{#453198} Committed: https://chromium.googlesource.com/chromium/src/+/02ba668f1ae4306618c08ef19ed5d85ed4d481d2

Patch Set 1 #

Patch Set 2 : Add some tests to idl_types_test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -1 line) Patch
M third_party/WebKit/Source/bindings/scripts/idl_definitions.py View 3 chunks +24 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/scripts/idl_types.py View 1 chunk +44 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/idl_types_test.py View 1 2 chunks +58 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Raphael Kubo da Costa (rakuco)
PTAL. These are the least controversial parts of https://codereview.chromium.org/2709983004/
3 years, 9 months ago (2017-02-27 09:45:00 UTC) #1
haraken
LGTM
3 years, 9 months ago (2017-02-27 11:19:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719913002/20001
3 years, 9 months ago (2017-02-27 11:25:23 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/02ba668f1ae4306618c08ef19ed5d85ed4d481d2
3 years, 9 months ago (2017-02-27 13:19:39 UTC) #7
bashi
3 years, 9 months ago (2017-02-27 23:06:44 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698