Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2719883005: Revert of Replace FFmpegDemuxer thread per element with base::TaskScheduler. (Closed)

Created:
3 years, 9 months ago by dvadym
Modified:
3 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Replace FFmpegDemuxer thread per element with base::TaskScheduler. (patchset #8 id:140001 of https://codereview.chromium.org/2710133003/ ) Reason for revert: It's most likely a culprit for failing test: http/tests/media/video-in-iframe-crash.html starting from https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/23846 Error message: [ERROR:render_media_log.cc(30)] MediaEvent: MEDIA_ERROR_LOG_ENTRY {"error":"FFmpegDemuxer: data source error"} Original issue's description: > Replace FFmpegDemuxer thread per element with base::TaskScheduler. > > I don't think we need to keep starting a thread per <audio> or > <video> element anymore. Instead we can use a shared pool that > only spins up a new thread when needed. > > This change switches FFmpegDemuxer from creating its own thread > to using base::TaskScheduler for executing blocking network reads. > The TaskScheduler API is perfectly suited for our use case and > required little changes. > > Doing this required some changes to our BlockingUrlProtocol to > make it safe to access after FFmpegDemuxer and potentially the > DataSource have been destroyed. > > This should reduce the number of out of threads crashes we see on > a fairly regular basis. > > BUG=61293 > TEST=existing tests all pass, no slowdown noticed on pages like gfycat.com > > Review-Url: https://codereview.chromium.org/2710133003 > Cr-Commit-Position: refs/heads/master@{#453470} > Committed: https://chromium.googlesource.com/chromium/src/+/5384b9fe1cf67869e1bf98ab8ff6bd21ae4216da TBR=gab@chromium.org,halliwell@chromium.org,xhwang@chromium.org,dalecurtis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=61293 Review-Url: https://codereview.chromium.org/2719883005 Cr-Commit-Position: refs/heads/master@{#453563} Committed: https://chromium.googlesource.com/chromium/src/+/584b59ac597f611fbac882fbbe90d538bf60db4e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -159 lines) Patch
M chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc View 25 chunks +41 lines, -4 lines 0 comments Download
M media/base/demuxer_perftest.cc View 4 chunks +26 lines, -24 lines 0 comments Download
M media/filters/blocking_url_protocol.h View 3 chunks +5 lines, -12 lines 0 comments Download
M media/filters/blocking_url_protocol.cc View 4 chunks +16 lines, -28 lines 0 comments Download
M media/filters/blocking_url_protocol_unittest.cc View 5 chunks +30 lines, -34 lines 0 comments Download
M media/filters/ffmpeg_demuxer.h View 2 chunks +3 lines, -9 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 15 chunks +29 lines, -33 lines 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 5 chunks +4 lines, -7 lines 0 comments Download
M media/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M media/test/pipeline_integration_test.cc View 1 chunk +5 lines, -1 line 0 comments Download
M media/test/pipeline_integration_test_base.h View 2 chunks +0 lines, -4 lines 0 comments Download
M media/test/pipeline_integration_test_base.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dvadym
Created Revert of Replace FFmpegDemuxer thread per element with base::TaskScheduler.
3 years, 9 months ago (2017-02-28 10:13:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719883005/1
3 years, 9 months ago (2017-02-28 10:13:27 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 10:14:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/584b59ac597f611fbac882fbbe90...

Powered by Google App Engine
This is Rietveld 408576698