Don't attach NetworkStateObserver until Document is initialized/attached

Don't attach NetworkStateObserver until Document is initialized/attached

BUG=695783
TEST=See the bug page

Review-Url: https://codereview.chromium.org/2719873002
Cr-Commit-Position: refs/heads/master@{#453183}
Committed: https://chromium.googlesource.com/chromium/src/+/6e78ba0f584de89a6abc55d43c283fb16a4b3afd

[kinuko, 2017-02-27 06:40:27]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 06:40:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2017-02-27 06:43:18]

Description was changed from

==========
Don't attach NetworkStateObserver until Document is initialized/attached

BUG=695783
==========

to

==========
Don't attach NetworkStateObserver until Document is initialized/attached

BUG=695783
TEST=See the bug page
==========

[kinuko, 2017-02-27 06:44:54]

kinuko@chromium.org changed reviewers:
+ dcheng@chromium.org, haraken@chromium.org, jkarlin@chromium.org,
sigbjornf@opera.com

[kinuko, 2017-02-27 06:47:39]

(From https://codereview.chromium.org/2714643008/)

Would this look more preferable?

[haraken, 2017-02-27 07:49:18]

On 2017/02/27 06:47:39, kinuko wrote:
> (From https://codereview.chromium.org/2714643008/)
> 
> Would this look more preferable?

LGTM

Yeah, we need this kind of code refactoring to make sure that context lifecycle
observers are not attached to a Document that isn't attached to a frame.

[dcheng, 2017-02-27 07:52:18]

LGTM

[sof, 2017-02-27 07:54:33]

lgtm

https://codereview.chromium.org/2719873002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/2719873002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Document.cpp:2448: m_networkStateObserver =
new NetworkStateObserver(*this);
Could you add a short explanatory comment why this is done here?

[kinuko, 2017-02-27 09:15:05]

Thanks!

https://codereview.chromium.org/2719873002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/2719873002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Document.cpp:2448: m_networkStateObserver =
new NetworkStateObserver(*this);
On 2017/02/27 07:54:33, sof wrote:
> Could you add a short explanatory comment why this is done here?

Done.

[kinuko, 2017-02-27 09:15:10]

The CQ bit was checked by kinuko@chromium.org

[kinuko, 2017-02-27 09:15:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, sigbjornf@opera.com, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2719873002/#ps20001
(title: "comment")

[commit-bot: I haz the power, 2017-02-27 09:15:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 10:41:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488186910017650,
"parent_rev": "c5ee1e29d253c181895b2f60282f7c4c8ae466a0", "commit_rev":
"6e78ba0f584de89a6abc55d43c283fb16a4b3afd"}

[commit-bot: I haz the power, 2017-02-27 10:42:24]

Description was changed from

==========
Don't attach NetworkStateObserver until Document is initialized/attached

BUG=695783
TEST=See the bug page
==========

to

==========
Don't attach NetworkStateObserver until Document is initialized/attached

BUG=695783
TEST=See the bug page

Review-Url: https://codereview.chromium.org/2719873002
Cr-Commit-Position: refs/heads/master@{#453183}
Committed:
https://chromium.googlesource.com/chromium/src/+/6e78ba0f584de89a6abc55d43c28...
==========

[commit-bot: I haz the power, 2017-02-27 10:42:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6e78ba0f584de89a6abc55d43c28...