tools/perf/measurements/multipage_skpicture_printer.py - Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/multipage_skpicture_printer.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/multipage_skpicture_printer.py

diff --git a/tools/perf/measurements/multipage_skpicture_printer.py b/tools/perf/measurements/multipage_skpicture_printer.py

index c92d836857ced8e472203fa3178b5b2f596ed8d2..aa03c08fc377966787463112e09c2cdf250d7d61 100644

--- a/tools/perf/measurements/multipage_skpicture_printer.py

+++ b/tools/perf/measurements/multipage_skpicture_printer.py

@@ -26,6 +26,6 @@ class MultipageSkpicturePrinter(legacy_page_test.LegacyPageTest):

os.path.join(self._mskp_outdir, page.file_safe_name + '.mskp'))

# Replace win32 path separator char '\' with '\\'.

outpath = outpath.replace('\\', '\\\\')

- tab.EvaluateJavaScript2(

+ tab.EvaluateJavaScript(

'chrome.gpuBenchmarking.printPagesToSkPictures({{ outpath }});',

outpath=outpath)