tools/perf/page_sets/maps.py - Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/page_sets/maps.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/perf/page_sets/login_helpers/login_utils.py ('k') | tools/perf/page_sets/mobile_infinite_scroll_cases.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from telemetry.page import page as page_module	5 from telemetry.page import page as page_module

6 from telemetry import story	6 from telemetry import story

7	7

8 from page_sets import webgl_supported_shared_state	8 from page_sets import webgl_supported_shared_state

9	9

10	10

(...skipping 11 matching lines...) Expand all Loading...
22 def skipped_gpus(self):	22 def skipped_gpus(self):

23 # Skip this intensive test on low-end devices. crbug.com/464731	23 # Skip this intensive test on low-end devices. crbug.com/464731

24 return ['arm']	24 return ['arm']

25	25

26 def RunNavigateSteps(self, action_runner):	26 def RunNavigateSteps(self, action_runner):

27 super(MapsPage, self).RunNavigateSteps(action_runner)	27 super(MapsPage, self).RunNavigateSteps(action_runner)

28 action_runner.Wait(3)	28 action_runner.Wait(3)

29	29

30 def RunPageInteractions(self, action_runner):	30 def RunPageInteractions(self, action_runner):

31 with action_runner.CreateInteraction('MapAnimation'):	31 with action_runner.CreateInteraction('MapAnimation'):

32 action_runner.WaitForJavaScriptCondition2(	32 action_runner.WaitForJavaScriptCondition(

33 'window.testMetrics != undefined', timeout=120)	33 'window.testMetrics != undefined', timeout=120)

34	34

35	35

36 class MapsPageSet(story.StorySet):	36 class MapsPageSet(story.StorySet):

37	37

38 """ Google Maps examples """	38 """ Google Maps examples """

39	39

40 def __init__(self):	40 def __init__(self):

41 super(MapsPageSet, self).__init__(	41 super(MapsPageSet, self).__init__(

42 archive_data_file='data/maps.json',	42 archive_data_file='data/maps.json',

43 cloud_storage_bucket=story.PUBLIC_BUCKET)	43 cloud_storage_bucket=story.PUBLIC_BUCKET)

44	44

45 self.AddStory(MapsPage(self))	45 self.AddStory(MapsPage(self))

OLD	NEW