Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: tools/perf/page_sets/key_mobile_sites_smooth.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/page_sets/key_mobile_sites_pages.py ('k') | tools/perf/page_sets/key_silk_cases.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 from telemetry.page import page as page_module 4 from telemetry.page import page as page_module
5 from telemetry.page import shared_page_state 5 from telemetry.page import shared_page_state
6 from telemetry import story 6 from telemetry import story
7 7
8 from page_sets import key_mobile_sites_pages 8 from page_sets import key_mobile_sites_pages
9 9
10 10
(...skipping 16 matching lines...) Expand all
27 action_on_load_complete=False): 27 action_on_load_complete=False):
28 super(KeyMobileSitesSmoothPage, self).__init__( 28 super(KeyMobileSitesSmoothPage, self).__init__(
29 url=url, page_set=page_set, name=name, 29 url=url, page_set=page_set, name=name,
30 credentials_path='data/credentials.json', tags=tags, 30 credentials_path='data/credentials.json', tags=tags,
31 shared_page_state_class=shared_page_state.SharedMobilePageState) 31 shared_page_state_class=shared_page_state.SharedMobilePageState)
32 self.archive_data_file = 'data/key_mobile_sites.json' 32 self.archive_data_file = 'data/key_mobile_sites.json'
33 self.action_on_load_complete = action_on_load_complete 33 self.action_on_load_complete = action_on_load_complete
34 34
35 def RunPageInteractions(self, action_runner): 35 def RunPageInteractions(self, action_runner):
36 if self.action_on_load_complete: 36 if self.action_on_load_complete:
37 action_runner.WaitForJavaScriptCondition2( 37 action_runner.WaitForJavaScriptCondition(
38 'document.readyState == "complete"', timeout=30) 38 'document.readyState == "complete"', timeout=30)
39 _IssueMarkerAndScroll(action_runner) 39 _IssueMarkerAndScroll(action_runner)
40 40
41 41
42 class LinkedInSmoothPage(key_mobile_sites_pages.LinkedInPage): 42 class LinkedInSmoothPage(key_mobile_sites_pages.LinkedInPage):
43 43
44 def __init__(self, page_set): 44 def __init__(self, page_set):
45 super(LinkedInSmoothPage, self).__init__(page_set=page_set) 45 super(LinkedInSmoothPage, self).__init__(page_set=page_set)
46 46
47 # Linkedin has expensive shader compilation so it can benefit from shader 47 # Linkedin has expensive shader compilation so it can benefit from shader
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 ('http://www.baidu.com/s?wd=barack+obama&rsv_bp=0&rsv_spt=3&rsv_sug3=9&' 284 ('http://www.baidu.com/s?wd=barack+obama&rsv_bp=0&rsv_spt=3&rsv_sug3=9&'
285 'rsv_sug=0&rsv_sug4=3824&rsv_sug1=3&inputT=4920'), 285 'rsv_sug=0&rsv_sug4=3824&rsv_sug1=3&inputT=4920'),
286 # Why: Top search engine 286 # Why: Top search engine
287 'http://www.bing.com/search?q=sloths', 287 'http://www.bing.com/search?q=sloths',
288 # Why: Good example of poor initial scrolling 288 # Why: Good example of poor initial scrolling
289 'http://ftw.usatoday.com/2014/05/spelling-bee-rules-shenanigans' 289 'http://ftw.usatoday.com/2014/05/spelling-bee-rules-shenanigans'
290 ] 290 ]
291 291
292 for url in urls_list: 292 for url in urls_list:
293 self.AddStory(KeyMobileSitesSmoothPage(url, self)) 293 self.AddStory(KeyMobileSitesSmoothPage(url, self))
OLDNEW
« no previous file with comments | « tools/perf/page_sets/key_mobile_sites_pages.py ('k') | tools/perf/page_sets/key_silk_cases.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698