Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2719823002: grit: Absolute includes for shell_resources.h (Closed)

Created:
3 years, 9 months ago by Nico
Modified:
3 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, tfarina, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

grit: Absolute includes for shell_resources.h Also qualify a straggler include of theme_resource.h (but the .gn file can't set use_qualified_include=true for this one yet until grit writes a qualified include for the generated _map.cc file). BUG=401588 Review-Url: https://codereview.chromium.org/2719823002 Cr-Commit-Position: refs/heads/master@{#453209} Committed: https://chromium.googlesource.com/chromium/src/+/da47dac5f72b5289fb1155d1f73497ed26afac2a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M apps/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M apps/ui/views/app_window_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_devtools_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/common/shell_content_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Nico
Tapted: apps/ Avi: content/
3 years, 9 months ago (2017-02-27 03:15:21 UTC) #6
Avi (use Gerrit)
lgtm
3 years, 9 months ago (2017-02-27 03:18:45 UTC) #7
tapted
apps/ lgtm
3 years, 9 months ago (2017-02-27 03:27:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719823002/1
3 years, 9 months ago (2017-02-27 14:31:47 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 14:36:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/da47dac5f72b5289fb1155d1f734...

Powered by Google App Engine
This is Rietveld 408576698