Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 2719813004: selection: Update addRange-nn.html for 20170227 draft. (Closed)

Created:
3 years, 9 months ago by tkent
Modified:
3 years, 9 months ago
Reviewers:
yoichio, yosin_UTC9
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

selection: Update addRange-nn.html for 20170227 draft. addRange() behavior was updated so that it does nothing if rangeCount > 0. https://www.w3.org/TR/2017/WD-selection-api-20170227/#dom-selection-addrange BUG=683066 Review-Url: https://codereview.chromium.org/2719813004 Cr-Commit-Position: refs/heads/master@{#453498} Committed: https://chromium.googlesource.com/chromium/src/+/eb9a657134f60d44627d5f768e4db1035cfa0849

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -19092 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/selection/addRange.js View 3 chunks +18 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/selection/addRange-00-expected.txt View 1 chunk +0 lines, -2641 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/selection/addRange-04-expected.txt View 1 chunk +0 lines, -2641 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/selection/addRange-12-expected.txt View 1 chunk +0 lines, -1439 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/selection/addRange-16-expected.txt View 1 chunk +0 lines, -2040 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/selection/addRange-20-expected.txt View 1 chunk +0 lines, -1439 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/selection/addRange-24-expected.txt View 1 chunk +0 lines, -1555 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/selection/addRange-28-expected.txt View 1 chunk +0 lines, -2641 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/selection/addRange-32-expected.txt View 1 chunk +0 lines, -2040 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/selection/addRange-36-expected.txt View 1 chunk +0 lines, -2641 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/common.js View 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
tkent
yoichio@, yosin@, would you review this please? This resolves 3,136 FAILs.
3 years, 9 months ago (2017-02-28 01:58:18 UTC) #4
yosin_UTC9
lgtm
3 years, 9 months ago (2017-02-28 02:20:40 UTC) #5
yoichio
Many addRange-nn.html are completely passed! yay! lgtm!
3 years, 9 months ago (2017-02-28 02:24:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719813004/1
3 years, 9 months ago (2017-02-28 03:20:09 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 04:46:17 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eb9a657134f60d44627d5f768e4d...

Powered by Google App Engine
This is Rietveld 408576698