Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 271973002: Revert 268933 "Helpful message for not checking SupportsMultiple..." (Closed)

Created:
6 years, 7 months ago by oshima
Modified:
6 years, 7 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 268933 "Helpful message for not checking SupportsMultiple..." Speculative revert to see if this fixes massive test failures on win bot. > Helpful message for not checking SupportsMultipleDisplays on Win7 tests. > > "Multiple display test does not work on Windows bots. Please skip (don't > disable) the test using SupportsMultipleDisplays()" > > Previously, this message only showed on Windows 8 if you forget to check > SupportsMultipleDisplays in a test with multiple displays. Now it shows > on Windows 7 as well. > > Without this message, you get a much more confusing crash. > > BUG=370796 > > Review URL: https://codereview.chromium.org/270253003 TBR=mgiuca@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269081

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M trunk/src/ash/display/display_manager.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
oshima
6 years, 7 months ago (2014-05-08 20:18:09 UTC) #1
oshima
6 years, 7 months ago (2014-05-08 20:18:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r269081 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698