Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 270253003: Helpful message for not checking SupportsMultipleDisplays on Win7 tests. (Closed)

Created:
6 years, 7 months ago by Matt Giuca
Modified:
6 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, ananta, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Helpful message for not checking SupportsMultipleDisplays on Win7 tests. "Multiple display test does not work on Windows bots. Please skip (don't disable) the test using SupportsMultipleDisplays()" Previously, this message only showed on Windows 8 if you forget to check SupportsMultipleDisplays in a test with multiple displays. Now it shows on Windows 7 as well. Without this message, you get a much more confusing crash. BUG=370796 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268933 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269700

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M ash/display/display_manager.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Matt Giuca
6 years, 7 months ago (2014-05-07 08:31:54 UTC) #1
Matt Giuca
See bug report for full rationale.
6 years, 7 months ago (2014-05-07 08:32:06 UTC) #2
oshima
lgtm
6 years, 7 months ago (2014-05-07 13:58:11 UTC) #3
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 7 months ago (2014-05-07 14:16:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/270253003/1
6 years, 7 months ago (2014-05-07 14:20:45 UTC) #5
commit-bot: I haz the power
Change committed as 268933
6 years, 7 months ago (2014-05-07 20:43:03 UTC) #6
Matt Giuca
This was reverted in SVN 269081 (https://codereview.chromium.org/271973002). I doubt it had anything to do with ...
6 years, 7 months ago (2014-05-09 01:37:16 UTC) #7
oshima
On 2014/05/09 01:37:16, Matt Giuca wrote: > This was reverted in SVN 269081 (https://codereview.chromium.org/271973002). I ...
6 years, 7 months ago (2014-05-09 17:20:09 UTC) #8
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 7 months ago (2014-05-11 03:56:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/270253003/1
6 years, 7 months ago (2014-05-11 03:56:57 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 05:14:08 UTC) #11
Message was sent while issue was closed.
Change committed as 269700

Powered by Google App Engine
This is Rietveld 408576698