Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2719703004: Revert of Roll breakpad 37070c5..eaedc45 (Closed)

Created:
3 years, 9 months ago by scottmg
Modified:
3 years, 9 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, georgekola_google.com, jperaza, tobiasjs, vapier
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll breakpad 37070c5..eaedc45 (patchset #2 id:20001 of https://codereview.chromium.org/2719553002/ ) Reason for revert: Likely causing crbug.com/696257. Original issue's description: > Roll breakpad 37070c5..eaedc45 > > eaedc45 Improve stack sanitization unittests. > 0ca6751 Handle ntdll only emitting PUBLIC at func entry > c7e826f Make stack sanitization elide pointers to non-executable mappings. > 918f3dc Use the correct PC when determining whether to skip storing a stack. > f9d3ab8 minidump: mark Read as override in derived classes > 3ff7ca4 Fix compile errors arising from compiling breakpad with clang. > 3996c1b libdisasm: add upstream/license details > 603f8b6 There is no need to use the main queue just for perform selector. > e6123b1 Appveyor CI for Windows MSVS build > 376784d processor: drop set-but-unused variable > 122d65d macho_reader_unittest: use EXPECT_FALSE > 093fab2 windows: fix build on pre-Win10 systems > 620e0fb windows: update gtest/gmock paths > fc92bb3 fix write() unused-result warning > d5f233d Fixed leak of unloaded module lists. > > symupload.exe was built by generating a vsproj using gyp, and building a > Release build in VS 2015. > > R=thestig@chromium.org > BUG=678874 > > Review-Url: https://codereview.chromium.org/2719553002 > Cr-Commit-Position: refs/heads/master@{#452979} > Committed: https://chromium.googlesource.com/chromium/src/+/12a3f61803fefb0aeb06f3f4093ea8b06a29fbb3 TBR=thestig@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=678874 Review-Url: https://codereview.chromium.org/2719703004 Cr-Commit-Position: refs/heads/master@{#453115} Committed: https://chromium.googlesource.com/chromium/src/+/f1b19ba2112904f307bd9a7d59f1e6bace633e89

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M breakpad/symupload.exe View Binary file 0 comments Download

Messages

Total messages: 7 (3 generated)
scottmg
Created Revert of Roll breakpad 37070c5..eaedc45
3 years, 9 months ago (2017-02-26 06:05:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719703004/1
3 years, 9 months ago (2017-02-26 06:05:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f1b19ba2112904f307bd9a7d59f1e6bace633e89
3 years, 9 months ago (2017-02-26 07:04:00 UTC) #6
Lei Zhang
3 years, 9 months ago (2017-02-27 19:47:26 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698