Enforce FCM settings via the blacklist rather than in-code version checks.

Enforce FCM settings via the blacklist rather than in-code version checks.

As of http://crrev.com/228816 both Win and Mac bots are properly using the blacklist and version checks in compositor_util.cc are no longer required.

Also cleanup the blacklist to:
1) Put Vista and XP blacklisting of FCM under the same rule.
2) Always blacklist Stage3D when FCM is disabled (as in https://codereview.chromium.org/25602002).

This is part of https://codereview.chromium.org/22198004/ which was split out into smaller chunks (now a follow-up to https://codereview.chromium.org/23703017/).

BUG=302738, 233830, 306557
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229309

[gab, 2013-10-16 18:06:17]

Mo/Vangelis, PTAL.

Thanks!
Gab

[Zhenyao Mo, 2013-10-16 19:03:48]

With this, we will lose flash 3d on XP.  Please wait until jbauman sign off this
CL, as he enabled flash 3d on XP before.

Other than that, LGTM

[jbauman, 2013-10-17 00:33:24]

On 2013/10/16 19:03:48, Zhenyao Mo wrote:
> With this, we will lose flash 3d on XP.  Please wait until jbauman sign off
this
> CL, as he enabled flash 3d on XP before.
> 
> Other than that, LGTM

lgtm. Though this will disable GPU acceleration in aura on XP machines with
newer drivers, so be ready for the fallout.

[vangelis, 2013-10-17 05:37:48]

On 2013/10/17 00:33:24, jbauman wrote:
> On 2013/10/16 19:03:48, Zhenyao Mo wrote:
> > With this, we will lose flash 3d on XP.  Please wait until jbauman sign off
> this
> > CL, as he enabled flash 3d on XP before.
> > 
> > Other than that, LGTM
> 
> lgtm. Though this will disable GPU acceleration in aura on XP machines with
> newer drivers, so be ready for the fallout.

cc-ing Tom FYI

I think we were all in agreement that we can kill gpu acceleration on XP. Tom
were there any last minute change-of-hearts?

[gab, 2013-10-17 18:24:24]

On 2013/10/17 05:37:48, vangelis wrote:
> On 2013/10/17 00:33:24, jbauman wrote:
> > On 2013/10/16 19:03:48, Zhenyao Mo wrote:
> > > With this, we will lose flash 3d on XP.  Please wait until jbauman sign
off
> > this
> > > CL, as he enabled flash 3d on XP before.
> > > 
> > > Other than that, LGTM
> > 
> > lgtm. Though this will disable GPU acceleration in aura on XP machines with
> > newer drivers, so be ready for the fallout.
> 
> cc-ing Tom FYI
> 
> I think we were all in agreement that we can kill gpu acceleration on XP. Tom
> were there any last minute change-of-hearts?

So FCM was already never enabled on XP (i.e.
https://codereview.chromium.org/23703017/diff/294012/chrome/browser/gpu/chrom...
was replaced by the blacklist rule #79 in
https://codereview.chromium.org/23703017/).

So what I think is that XP used to use the legacy path, then we switched to Aura
so it started using the GPU (on the bots only) since aura forces FCM yet the
blacklist was disabled on the bots so it wouldn't kick back to software
compositing mode.

Yet we want it to kick into software compositing mode for all XP machines,
right?!

All this CL does is also blacklist flash_3d as jbauman's
https://codereview.chromium.org/25602002 said should be done whenever we
blacklist FCM.

[commit-bot: I haz the power, 2013-10-17 19:39:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/27197009/11001

[commit-bot: I haz the power, 2013-10-17 22:07:21]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2013-10-17 23:20:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/27197009/11001

[commit-bot: I haz the power, 2013-10-18 01:38:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/27197009/11001

[commit-bot: I haz the power, 2013-10-18 04:00:05]

Change committed as 229309

[vangelis, 2013-10-18 05:22:51]

On 2013/10/17 00:33:24, jbauman wrote:
> On 2013/10/16 19:03:48, Zhenyao Mo wrote:
> > With this, we will lose flash 3d on XP.  Please wait until jbauman sign off
> this
> > CL, as he enabled flash 3d on XP before.
> > 
> > Other than that, LGTM
> 
> lgtm. Though this will disable GPU acceleration in aura on XP machines with
> newer drivers, so be ready for the fallout.

John, is TCM needed for the software compositor to kick in?

[jbauman, 2013-10-18 05:35:23]

On 2013/10/18 05:22:51, vangelis wrote:
> On 2013/10/17 00:33:24, jbauman wrote:
> > On 2013/10/16 19:03:48, Zhenyao Mo wrote:
> > > With this, we will lose flash 3d on XP.  Please wait until jbauman sign
off
> > this
> > > CL, as he enabled flash 3d on XP before.
> > > 
> > > Other than that, LGTM
> > 
> > lgtm. Though this will disable GPU acceleration in aura on XP machines with
> > newer drivers, so be ready for the fallout.
> 
> John, is TCM needed for the software compositor to kick in?

No. The software compositor is always available on win aura. The GPU is used if
it works and if neither accelerated compositing nor force compositing mode nor
webgl are blacklisted, and the software compositor is used otherwise.

I'd prefer that we always use TCM (in the renderer) when the software compositor
could be used, but they're orthogonal.

[vangelis, 2013-10-18 16:30:32]

On 2013/10/18 05:35:23, jbauman wrote:
> On 2013/10/18 05:22:51, vangelis wrote:
> > On 2013/10/17 00:33:24, jbauman wrote:
> > > On 2013/10/16 19:03:48, Zhenyao Mo wrote:
> > > > With this, we will lose flash 3d on XP.  Please wait until jbauman sign
> off
> > > this
> > > > CL, as he enabled flash 3d on XP before.
> > > > 
> > > > Other than that, LGTM
> > > 
> > > lgtm. Though this will disable GPU acceleration in aura on XP machines
with
> > > newer drivers, so be ready for the fallout.
> > 
> > John, is TCM needed for the software compositor to kick in?
> 
> No. The software compositor is always available on win aura. The GPU is used
if
> it works and if neither accelerated compositing nor force compositing mode nor
> webgl are blacklisted, and the software compositor is used otherwise.
> 
> I'd prefer that we always use TCM (in the renderer) when the software
compositor
> could be used, but they're orthogonal.

To clarify for my own sake, what mode do we end up if we are on a (Aura Windows)
machine in which we blacklist force_compositing_mode and there's no GPU
available? Will it be the threaded software compositor or something else?
Because according to the new logic, if FCM is blacklisted then TCM won't kick in
either.

[gab, 2013-10-18 16:36:22]

On 2013/10/18 16:30:32, vangelis wrote:
> On 2013/10/18 05:35:23, jbauman wrote:
> > On 2013/10/18 05:22:51, vangelis wrote:
> > > On 2013/10/17 00:33:24, jbauman wrote:
> > > > On 2013/10/16 19:03:48, Zhenyao Mo wrote:
> > > > > With this, we will lose flash 3d on XP.  Please wait until jbauman
sign
> > off
> > > > this
> > > > > CL, as he enabled flash 3d on XP before.
> > > > > 
> > > > > Other than that, LGTM
> > > > 
> > > > lgtm. Though this will disable GPU acceleration in aura on XP machines
> with
> > > > newer drivers, so be ready for the fallout.
> > > 
> > > John, is TCM needed for the software compositor to kick in?
> > 
> > No. The software compositor is always available on win aura. The GPU is used
> if
> > it works and if neither accelerated compositing nor force compositing mode
nor
> > webgl are blacklisted, and the software compositor is used otherwise.
> > 
> > I'd prefer that we always use TCM (in the renderer) when the software
> compositor
> > could be used, but they're orthogonal.
> 
> To clarify for my own sake, what mode do we end up if we are on a (Aura
Windows)
> machine in which we blacklist force_compositing_mode and there's no GPU
> available? Will it be the threaded software compositor or something else?
> Because according to the new logic, if FCM is blacklisted then TCM won't kick
in
> either.

FCM/TCM are hardcoded to true on Aura (i.e., the blacklist has no effect to the
result of the methods in compositor_util.cc), but then another check (I forget
where) verifies if FCM is blacklisted and if so kicks into software compositing
mode.

[vangelis, 2013-10-18 16:38:06]

On 2013/10/18 16:36:22, gab wrote:
> On 2013/10/18 16:30:32, vangelis wrote:
> > On 2013/10/18 05:35:23, jbauman wrote:
> > > On 2013/10/18 05:22:51, vangelis wrote:
> > > > On 2013/10/17 00:33:24, jbauman wrote:
> > > > > On 2013/10/16 19:03:48, Zhenyao Mo wrote:
> > > > > > With this, we will lose flash 3d on XP.  Please wait until jbauman
> sign
> > > off
> > > > > this
> > > > > > CL, as he enabled flash 3d on XP before.
> > > > > > 
> > > > > > Other than that, LGTM
> > > > > 
> > > > > lgtm. Though this will disable GPU acceleration in aura on XP machines
> > with
> > > > > newer drivers, so be ready for the fallout.
> > > > 
> > > > John, is TCM needed for the software compositor to kick in?
> > > 
> > > No. The software compositor is always available on win aura. The GPU is
used
> > if
> > > it works and if neither accelerated compositing nor force compositing mode
> nor
> > > webgl are blacklisted, and the software compositor is used otherwise.
> > > 
> > > I'd prefer that we always use TCM (in the renderer) when the software
> > compositor
> > > could be used, but they're orthogonal.
> > 
> > To clarify for my own sake, what mode do we end up if we are on a (Aura
> Windows)
> > machine in which we blacklist force_compositing_mode and there's no GPU
> > available? Will it be the threaded software compositor or something else?
> > Because according to the new logic, if FCM is blacklisted then TCM won't
kick
> in
> > either.
> 
> FCM/TCM are hardcoded to true on Aura (i.e., the blacklist has no effect to
the
> result of the methods in compositor_util.cc), but then another check (I forget
> where) verifies if FCM is blacklisted and if so kicks into software
compositing
> mode.

Ah, right! Thanks, Gab!

[wiltzius, 2013-10-18 22:13:01]

Yeah to be clear the desired configuration is:

On Vista and XP: always use software compositor, always use TCM, never
allow any hardware acceleration features like Stage3D.
On Win7/8: always use threaded compositor, and optionally individually
disable hardware features for Stage3D, accelerated video, Canvas2D, WebGL.
Also optionally disable hardware threaded compositing in favor of software
threaded compositing, in which case all of the other features should also
be automatically disabled.

Make sense?

There's an additional requirement, though, that we need to worry about for
M32 -- if all hardware acceleration features are blacklisted, I want us to
uncheck the "use hardware acceleration" checkbox in Chrome's settings. If
the user checks it again, we can run Chrome with full capabilities -- the
equivalent of "ignore-gpu-blacklist". The box should only have this
behavior if *all* features are disabled (i.e. if they get software
compositing). If only a couple features are (e.g. only Canvas2D) then the
box should remain checked by default and unchecking it should force them
into full software mode. I will file a bug about this, it's a separate
issue, but just thought I'd mention here in case its relevant.

On Friday, October 18, 2013, wrote:

> On 2013/10/18 05:22:51, vangelis wrote:
>
>> On 2013/10/17 00:33:24, jbauman wrote:
>> > On 2013/10/16 19:03:48, Zhenyao Mo wrote:
>> > > With this, we will lose flash 3d on XP.  Please wait until jbauman
>> sign
>>
> off
>
>> > this
>> > > CL, as he enabled flash 3d on XP before.
>> > >
>> > > Other than that, LGTM
>> >
>> > lgtm. Though this will disable GPU acceleration in aura on XP machines
>> with
>> > newer drivers, so be ready for the fallout.
>>
>
>  John, is TCM needed for the software compositor to kick in?
>>
>
> No. The software compositor is always available on win aura. The GPU is
> used if
> it works and if neither accelerated compositing nor force compositing mode
> nor
> webgl are blacklisted, and the software compositor is used otherwise.
>
> I'd prefer that we always use TCM (in the renderer) when the software
> compositor
> could be used, but they're orthogonal.
>
>
https://codereview.chromium.**org/27197009/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[vangelis, 2013-10-21 02:54:45]

On Fri, Oct 18, 2013 at 3:12 PM, Tom Wiltzius <wiltzius@chromium.org> wrote:

> Yeah to be clear the desired configuration is:
>
> On Vista and XP: always use software compositor, always use TCM, never
> allow any hardware acceleration features like Stage3D.
> On Win7/8: always use threaded compositor, and optionally individually
> disable hardware features for Stage3D, accelerated video, Canvas2D, WebGL.
> Also optionally disable hardware threaded compositing in favor of software
> threaded compositing, in which case all of the other features should also
> be automatically disabled.
>
> Make sense?
>
> There's an additional requirement, though, that we need to worry about for
> M32 -- if all hardware acceleration features are blacklisted, I want us to
> uncheck the "use hardware acceleration" checkbox in Chrome's settings. If
> the user checks it again, we can run Chrome with full capabilities -- the
> equivalent of "ignore-gpu-blacklist". The box should only have this
> behavior if *all* features are disabled (i.e. if they get software
> compositing). If only a couple features are (e.g. only Canvas2D) then the
> box should remain checked by default and unchecking it should force them
> into full software mode. I will file a bug about this, it's a separate
> issue, but just thought I'd mention here in case its relevant.
>

Tom, I'm assuming this last part only applies to Win7+ ? I don't think we
want to allow folks to enable gpu acceleration as over time it may no
longer be possible (e.g if we remove support for D3D9). Should we simply
remove that settings checkbox on XP + Vista?


>
> On Friday, October 18, 2013, wrote:
>
>> On 2013/10/18 05:22:51, vangelis wrote:
>>
>>> On 2013/10/17 00:33:24, jbauman wrote:
>>> > On 2013/10/16 19:03:48, Zhenyao Mo wrote:
>>> > > With this, we will lose flash 3d on XP.  Please wait until jbauman
>>> sign
>>>
>> off
>>
>>> > this
>>> > > CL, as he enabled flash 3d on XP before.
>>> > >
>>> > > Other than that, LGTM
>>> >
>>> > lgtm. Though this will disable GPU acceleration in aura on XP machines
>>> with
>>> > newer drivers, so be ready for the fallout.
>>>
>>
>>  John, is TCM needed for the software compositor to kick in?
>>>
>>
>> No. The software compositor is always available on win aura. The GPU is
>> used if
>> it works and if neither accelerated compositing nor force compositing
>> mode nor
>> webgl are blacklisted, and the software compositor is used otherwise.
>>
>> I'd prefer that we always use TCM (in the renderer) when the software
>> compositor
>> could be used, but they're orthogonal.
>>
>>
https://codereview.chromium.**org/27197009/<https://codereview.chromium.org/2...
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.