Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: content/browser/gpu/compositor_util.cc

Issue 27197009: Enforce FCM settings via the blacklist rather than in-code version checks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/config/software_rendering_list_json.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/gpu/compositor_util.cc
diff --git a/content/browser/gpu/compositor_util.cc b/content/browser/gpu/compositor_util.cc
index b764a0385aa3256300561ec91100c68182a1392c..45281efa50c796c62570221dfd5ffd146434dba3 100644
--- a/content/browser/gpu/compositor_util.cc
+++ b/content/browser/gpu/compositor_util.cc
@@ -91,18 +91,12 @@ bool IsForceCompositingModeEnabled() {
if (!CanDoAcceleratedCompositing() || IsForceCompositingModeBlacklisted())
return false;
- // Hardcode some platforms to use FCM, this has to be done here instead of via
- // the field trial so that this configuration is used on try bots as well.
- // TODO(gab): Do the same thing in IsThreadedCompositingEnabled() once this is
- // stable.
- // TODO(gab): Use the GPU blacklist instead of hardcoding OS versions here
- // https://codereview.chromium.org/23534006.
-#if defined(OS_MACOSX)
- // Mac OSX 10.8+ has been shipping with FCM enabled at 100% since M28.
- return base::mac::IsOSMountainLionOrLater();
-#elif defined(OS_WIN)
- // Windows Vista+ has been shipping with FCM enabled at 100% since M24.
- return base::win::GetVersion() >= base::win::VERSION_VISTA;
+// TODO(gab): Do the same thing for TCM above once this is stable.
+#if defined(OS_MACOSX) || defined(OS_WIN)
+ // Windows Vista+ has been shipping with FCM enabled at 100% since M24 and
+ // Mac OSX 10.8+ since M28. The blacklist check above takes care of returning
+ // false before this hits on unsupported Win/Mac versions.
+ return true;
#endif
return false;
« no previous file with comments | « no previous file | gpu/config/software_rendering_list_json.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698