Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 2719633002: Add descriptions with examples to run-blink-* scripts. (Closed)

Created:
3 years, 10 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
dcheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add descriptions with examples to run-blink-* scripts. This change adds docstrings to these scripts, and prints out these docstrings as description messages when -h is passed. BUG=692926 Review-Url: https://codereview.chromium.org/2719633002 Cr-Commit-Position: refs/heads/master@{#453217} Committed: https://chromium.googlesource.com/chromium/src/+/2c3d3754fd0305eb1c9f092efc7ce49fa76d8630

Patch Set 1 #

Patch Set 2 : Add docs for other scripts #

Total comments: 6

Patch Set 3 : Expand comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -10 lines) Patch
M third_party/WebKit/Tools/Scripts/run-blink-httpd View 1 2 1 chunk +21 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/run-blink-websocketserver View 1 2 1 chunk +12 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/run-blink-wptserve View 1 1 chunk +10 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/cli_wrapper.py View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/cli_wrapper_unittest.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
qyearsley
3 years, 10 months ago (2017-02-24 23:53:09 UTC) #2
dcheng
https://codereview.chromium.org/2719633002/diff/20001/third_party/WebKit/Tools/Scripts/run-blink-httpd File third_party/WebKit/Tools/Scripts/run-blink-httpd (right): https://codereview.chromium.org/2719633002/diff/20001/third_party/WebKit/Tools/Scripts/run-blink-httpd#newcode32 third_party/WebKit/Tools/Scripts/run-blink-httpd:32: After running this script, you can locally navigate to ...
3 years, 10 months ago (2017-02-25 00:06:24 UTC) #3
qyearsley
https://codereview.chromium.org/2719633002/diff/20001/third_party/WebKit/Tools/Scripts/run-blink-httpd File third_party/WebKit/Tools/Scripts/run-blink-httpd (right): https://codereview.chromium.org/2719633002/diff/20001/third_party/WebKit/Tools/Scripts/run-blink-httpd#newcode32 third_party/WebKit/Tools/Scripts/run-blink-httpd:32: After running this script, you can locally navigate to ...
3 years, 9 months ago (2017-02-26 19:21:45 UTC) #4
dcheng
lgtm
3 years, 9 months ago (2017-02-26 19:44:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719633002/40001
3 years, 9 months ago (2017-02-27 15:34:06 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 15:38:01 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2c3d3754fd0305eb1c9f092efc7c...

Powered by Google App Engine
This is Rietveld 408576698